Closed
Bug 277679
Opened 20 years ago
Closed 19 years ago
Whining scheduling does not display timezone
Categories
(Bugzilla :: Whining, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.22
People
(Reporter: Biesinger, Assigned: karl)
Details
Attachments
(1 file)
(deleted),
patch
|
jouni
:
review+
|
Details | Diff | Splinter Review |
Contrary to bug comments, the whining UI does not tell me which timezone the
times it offers me are in. hence, I'm unsure when I'll actually get that mail (I
suspect PST, in case of bmo...)
Assignee | ||
Comment 1•19 years ago
|
||
This is actually a touch more complicated then it looks. Right now all date&time computations are
performed using database queries, so we are actually interested in the database server's time zone.
That will change with bug 304989, which moves the date&time computations to the web server side,
instead of the database side.
However, given what I said above, it's probably safe to assume that the database server will be in the
same time zone as the web server.
Assignee | ||
Comment 2•19 years ago
|
||
This patch changes the template used by editwhines.cgi. At the end of the big
block of text at the top of the page, right before the whining events are
actually listed, I inserted a new paragraph. It simply says "All times are
server local time." If the local timezone was specified by the maintainer, it
is also included.
Yes, this is a bit inaccurate because all whining-related date&time
manipulations take place in the database, but I think I can safely make the
assumption that the database & web servers will be in the same timezone. This
will actually be moot when bug 195382 lands.
Requesting review from jouni.
Attachment #195609 -
Flags: review?(jouni)
Comment 3•19 years ago
|
||
Comment on attachment 195609 [details] [diff] [review]
Patch v1
r=jouni
Attachment #195609 -
Flags: review?(jouni) → review+
Updated•19 years ago
|
Assignee: erik → karl
Assignee | ||
Updated•19 years ago
|
Severity: normal → minor
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.22
Assignee | ||
Updated•19 years ago
|
Flags: approval?
Updated•19 years ago
|
Flags: approval? → approval+
Comment 4•19 years ago
|
||
Checking in template/en/default/whine/schedule.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/whine/schedule.html.tmpl,v
<-- schedule.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•