GetComments() is only USED inside of Bugzilla::Bug, anyhow. :-) This should be easy. I'll probably OO-ify it too, while I'm in there.

Oh, it's also used in process_bug. Whatever. We'll still put it in Bugzilla::Bug.

OK. I just moved GetComments in, because if I OO-ified it, I'd have to mess a lot with process_bug, and that's not really a part of this bug. I also removed the SendSQL stuff and changed it to use cool DBI stuff.

Comment on attachment 172327 [details] [diff] [review] Move GetComments and change to use Bugzilla->dbh As long as you're SURE that we don't need something similar to attachment 160409 [details] [diff] [review] in order to fix an eventual bug 261821, this looks good.

Yes, I'm sure. We always get all data from the object, so it will always be finished when we're done with it.

(In reply to comment #4) > Yes, I'm sure. We always get all data from the object, so it will always be > finished when we're done with it. IIRC, the routine in question in bug 261821 was retrieving all of the known data from the object as well, and it still hit that problem for some reason. But as long as we're not getting warnings from this, this is good.

It hit (In reply to comment #5) > IIRC, the routine in question in bug 261821 was retrieving all of the known data > from the object as well, and it still hit that problem for some reason. But as > long as we're not getting warnings from this, this is good. It hit the problem because it was a saved, global handle. (It's explained in the DBI docs pretty decently, actually.)

Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.290; previous revision: 1.289 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.230; previous revision: 1.229 done Checking in Bugzilla/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm new revision: 1.50; previous revision: 1.49 done