Closed
Bug 280438
Opened 20 years ago
Closed 20 years ago
tab gives away password when no title is defined
Categories
(Firefox :: Tabbed Browser, defect, P1)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox1.5
People
(Reporter: praseodym+mozbugzilla, Assigned: Gavin)
Details
(Keywords: fixed-aviary1.0.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mconnor
:
review+
dveditz
:
approval-aviary1.0.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0
When no title is defined, the tab bar shows the URL. However, it shows this
inluding the password if the url contains the password, e.g.:
http://user:pass@mark.givemehelp.co.uk/referer/1.html
The address bar will say http://mark.givemehelp.co.uk/referer/1.html and the tab
bar will say http://user:pass@mark.givemehelp.co.uk/referer/1.html.
Reproducible: Always
Steps to Reproduce:
|
||
Comment 1•20 years ago
|
||
ow. -> 1.1
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-aviary1.1+
|
Assignee | |
Updated•20 years ago
|
Assignee: bugs → gavin.sharp
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → Firefox1.1
Version: unspecified → Trunk
|
|
Assignee | |
Comment 2•20 years ago
|
||
Attachment #172920 -
Flags: review?(mconnor)
|
|
||
Comment 3•20 years ago
|
||
Comment on attachment 172920 [details] [diff] [review]
Patch
this action can fail, actually. Use the XPFE tabbrowser widget as the basis
here.
Attachment #172920 -
Flags: review?(mconnor) → review-
|
|
Assignee | |
Comment 4•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #172920 -
Attachment is obsolete: true
Attachment #172949 -
Flags: review?(mconnor)
|
|
||
Updated•20 years ago
|
Attachment #172949 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Updated•20 years ago
|
Whiteboard: [patch-r+] [checkin needed]
|
||
Comment 5•20 years ago
|
||
fixed on trunk (tabbrowser.xml, 1.67).
Whiteboard: [patch-r+] [checkin needed] → [fixed on trunk]
|
|
Assignee | |
Updated•20 years ago
|
Attachment #172949 -
Flags: approval-aviary1.0.1?
|
||
Comment 6•20 years ago
|
||
Dan, should we take this for 1.0.1?
|
||
Comment 7•20 years ago
|
||
Comment on attachment 172949 [details] [diff] [review]
Patch v2
a=dveditz for aviary1.0.1, please add the keyworkd "fixed-aviary1.0.1" when
checked in.
Not a blocker, though: get this in soon.
Attachment #172949 -
Flags: approval-aviary1.0.1? → approval-aviary1.0.1+
|
|
Assignee | |
Comment 8•20 years ago
|
||
I don't have CVS access, someone else will need to check this in.
|
|
||
Comment 9•20 years ago
|
||
Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v <-- tabbrowser.xml
new revision: 1.36.6.29.2.3; previous revision: 1.36.6.29.2.2
done
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0.1
Resolution: --- → FIXED
Whiteboard: [fixed on trunk]
|
||
Comment 10•20 years ago
|
||
Verified Fixed:
Aviary 1.0.1: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6)
Gecko/20050221 Firefox/1.0.1
Firefox Trunk: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050221 Firefox/1.0+
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•