Closed Bug 280497 Opened 20 years ago Closed 20 years ago

Replace "LIMIT" with Bugzilla::DB function call

Categories

(Bugzilla :: Bugzilla-General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: Tomas.Kopal, Assigned: Tomas.Kopal)

References

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050110 Firefox/1.0 (Debian package 1.0+dfsg.1-2) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050110 Firefox/1.0 (Debian package 1.0+dfsg.1-2) "LIMIT" have MySQL specific syntax and should be replaced with DB agnostic call to function in the DB compatibility layer. Reproducible: Always
Blocks: 280493
Attached patch V1 (deleted) — Splinter Review
Patch replacing all SQL LIMIT occurences with DB compat layer call.
Attachment #174194 - Flags: review?
Bug should be marked ASSIGNED and re-assigned to yourself, when you take them. :-)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → Bugzilla 2.20
Assignee: general → Tomas.Kopal
Status: ASSIGNED → NEW
Comment on attachment 174194 [details] [diff] [review] V1 r=mkanat by inspection.
Attachment #174194 - Flags: review? → review+
Flags: approval?
Status: NEW → ASSIGNED
so nobody's actually tested it?
(In reply to comment #4) > so nobody's actually tested it? I did :-).
fair enough
Flags: approval? → approval+
By the way, there was very minor bitrot from the other DBCompat patches, because some my $dbh statements had already been added. :-) (So no problem, really.) Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.281; previous revision: 1.280 done Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.345; previous revision: 1.344 done Checking in collectstats.pl; /cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v <-- collectstats.pl new revision: 1.41; previous revision: 1.40 done Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.303; previous revision: 1.302 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.236; previous revision: 1.235 done Checking in sanitycheck.cgi; /cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v <-- sanitycheck.cgi new revision: 1.79; previous revision: 1.78 done Checking in userprefs.cgi; /cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v <-- userprefs.cgi new revision: 1.66; previous revision: 1.65 done Checking in whine.pl; /cvsroot/mozilla/webtools/bugzilla/whine.pl,v <-- whine.pl new revision: 1.6; previous revision: 1.5 done Checking in Bugzilla/Search.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v <-- Search.pm new revision: 1.77; previous revision: 1.76 done Checking in Bugzilla/Token.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Token.pm,v <-- Token.pm new revision: 1.26; previous revision: 1.25 done Checking in Bugzilla/User.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v <-- User.pm new revision: 1.37; previous revision: 1.36 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Depends on: 281360
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: