Closed
Bug 280590
Opened 20 years ago
Closed 19 years ago
Pinstripe: Browser tabs should be focusable (when full keyboard access is on)
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
VERIFIED
FIXED
Firefox1.5
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: access)
Attachments
(1 file)
|
(deleted),
patch
|
mconnor
:
review+
shaver
:
approval-aviary1.1a2+
|
Details | Diff | Splinter Review |
Not as the window/*nix version, pinstripe tabs are not focusbale. We can't [yet]
fix native tabs (issues with mac focus rings...), but browser tabs are easy to fix.
|
Assignee | |
Comment 1•20 years ago
|
||
Kevin, any comments? (note: starting from latest builds, you should either turn
on fka or set the tabfocus pref in order to get the tabbar focusable)
|
||
Updated•20 years ago
|
OS: All → MacOS X
QA Contact: tabbed-browser → bugzilla
Flags: blocking-aviary1.1?
|
|
Assignee | |
Comment 2•20 years ago
|
||
Assigning this to Kevin. The attached style rules might be good enough, but i'm
not the theme owner.
Assignee: bugs → kevin
|
||
Comment 3•19 years ago
|
||
Comment on attachment 173023 [details] [diff] [review]
v1
We can tweak looks after, but we want to enable this to get some testing going.
This also enables the patch from bug 179656 to work with the keyboard, which is
a nice power-user touch.
Attachment #173023 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #173023 -
Flags: approval-aviary1.1a1?
|
|
Assignee | |
Updated•19 years ago
|
Attachment #173023 -
Flags: approval-aviary1.1a1? → approval-aviary1.1a2?
Comment on attachment 173023 [details] [diff] [review]
v1
a=shaver.
Attachment #173023 -
Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Flags: blocking-aviary1.1?
|
|
Assignee | |
Updated•19 years ago
|
Assignee: kevin → bugs.mano
|
|
Assignee | |
Comment 5•19 years ago
|
||
Checking in toolkit/themes/pinstripe/global/browser.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/browser.css,v <-- browser.css
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.1
|
||
Comment 6•19 years ago
|
||
There is a small error in that patch: padding can't be negative
> padding-top:-1px !important
Or do you want a bug filed for this ?
(btw, you better of using the outline property instead of border property, you
then could use outline-offset)
|
|
Assignee | |
Comment 7•19 years ago
|
||
fixed that typo.
|
||
Comment 8•19 years ago
|
||
See bug 296615, its about tabs being focused. Is this the intentional behavior?
|
|
||
Comment 9•19 years ago
|
||
interestingly, I can still focus browser tabs (via Tab key) even when full
keyboard access is off. tested with 2005060807-trunk deer park on OS X 10.4.1.
(and, of course, it also works when full keybd access is on.)
is this expected?
|
|
Assignee | |
Comment 10•19 years ago
|
||
(In reply to comment #9)
> interestingly, I can still focus browser tabs (via Tab key) even when full
> keyboard access is off. tested with 2005060807-trunk deer park on OS X 10.4.1.
> (and, of course, it also works when full keybd access is on.)
>
> is this expected?
Well, not really expected, I think (actually, not being able to focus them
partly erases the MoveTabs feature).
|
||
Comment 11•15 years ago
|
||
Bit late but verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.4pre) Gecko/20090918 Shiretoko/3.5.4pre ID:20090918030730
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → tabbed.browser
Hardware: PowerPC → All
You need to log in
before you can comment on or make changes to this bug.
Description
•