From Bug Helper: User-Agent: Mozilla/4.6C-NSCP (Macintosh; U; PPC) BuildID: 2000021608 search results in the sidebar should be single click as evidenced in the bug- o-rame and some causal in-house testing. I think this is the more usable bet for beta1 and likely expected by the majority of the users, based on what we know now. reasoning: there are no management tasks (ie. selection) required for items in the list, ie users are not going to re-arrange the results. Therefore double click is not needed and requiring it to launch a link is making it harder on users Reproducible: Always Steps to Reproduce: 1.run a search 2.open the sidebar search panel 3.attempt to launch one of the search results Actual Results: it require double click to launch a result Expected Results: single click should launch the result link

nominating for beta1 - we should get this right based on our best educated guess before we release to public

PDT-

No, we need a consistent story regarding single vs. double clicking... this is all covered in bug # 20455, so marking this a DUP of that. I'm going to be added search result filtering post beta1, so they can't be single-click. *** This bug has been marked as a duplicate of 20455 ***

VERIFIED Dupe

Reopen bug. Marking M14 since this is a highly desired fix, but keeping PDT- since this is not a show stopper. This week's usability tests strongly insist that we switch to one click for search results. This is not a dupe of bug 20455. That bug refers to the general question of single click vs double click in My Sidebar, and the basic answer is "it depends" since clearly html panels (the hundreds from other web sites) are single click and there are some client cases where we want double click. This bug is specifically about the Search panel. For beta 1, the Search results panel (and the What's Related panel) should be single click and underlined. Robert agrees with this for beta1.

Turning the links in Search panel and What's Related to one click and underlining is a low risk change and highly desirable. *Every* usability study so far has asked for this strongly. Renominating with Netcenter's input, removed PDT-

Johng, how do you know that this is low risk? It has never been done before with generated XUL content in the sidebar. (I have a small issue with making a change for beta1 that we might want to undo for post-beta1, too.)

Regardless, this bug REALLY IS a dup of 20455 for post-beta1.

Ben can easily hack this i would assume.

PDT- ...with growing risk... it is too late for beta1

As an intermediate fix... please just pick up the 4.7x license so we have that as our fall-back (if you have nothing).

Renominate 1 more time for PDT+. Single click with underlining as you mouse over for Search and What's Related panels. Just got usability feedback tonight with single click in the build and it was a huge success, a big part of the far more positive usability feedback we got tonight as compared to previous, double-click nights. Single-click made a big difference and is a low risk fix. Usability wants it, marketing wants it, Netcenter wants it, and we have the fix already written. This only effects the Search and What's Related panel - let's just do it

Putting on PDT+ radar for beta1.

Everyone wants it... but theer is only so much time to wait. When will this reportedly small fix land? Please add the info to the status whiteboard. Thanks, Jim

fix checked in (with bonus pref to soothe robert ;)

technically this is fixed but I want to mark it 'VERIFIED with extreme prejudice' because it's implemented poorly(IMHO). The very good single-click useability feedback mentioned was generated when the single-clickable links 'looked' like links(on mouseover). In this implementation sure they are single click links but they look like flat text. Nowhere is there a precedent for flat text that can be single clicked. I know how it works and i'm still surprised when i go to 'select' this flat text item and a page starts loading. ANyway, this is all for another UI bug I guess. marking VERIFIED with 2000030709 builds.

re-opened as this bug includes making the results appear as links which hasn't made it into the builds yet. It is important as claudius points out since we hagve changed to single for beta, but the appearanc needs to foolow along with it The fix has been tested and works locally here on Mac and PC. Add this to a search-panel.css file: treeitem > treerow.searchresult > treecell > titledbutton {    cursor: pointer; } treeitem > treerow.searchresult > treecell {    color: black;    text-decoration: none; } treeitem > treerow.searchresult > treecell:hover {    color: blue;    text-decoration: underline; } treeitem > treerow.searchresult > treecell > titledbutton:active {    color: red;    text-decoration: underline; } /*undo regular search tree selection look*/ treeitem[selected="true"] > treerow.searchresult {   background-color: transparent; } Then replace the line ins earch-panel.xul that says <treerow> with <treerow class="searchresult">.

erm, "fixed"

sigh. I only have the 2000030909 Linux build to look at right now but the search panel is completely broken right now.

I can confirm this on Mac as well, but it seems to have little to do with the changes made to fix this bug. Instead it seems to be related to the selection of engines based on search categories. Looks like the popup for search categories no longer works properly, in that it does not display the 'internet' category any longer and also in that it shows the last selected category twice. As a results serach does not get properly initiated from the panel, as no group of engines gets selected. I'll file this as bug. Once this aspect is verified we can close this one, as the single click functionality and the link appearance seem to work properly now based on Internet search prefs, which is why this bug was reopened in the first place. Can somebody verify that: a) when single click is selected in pref, the results show up as links on hover and load the URL on single click b) when double click is selected in pref, the results show up as selection on single click and load the URL on double click I will mark 'works for me' and once verified we can close.

The aspect mentioned in my post above works for me on Mac and Windows. Can somebody verify on Linux?

Looking at the 2000031009 builds. Nothing happens when I click on a search result link in the side panel, single-or-double nothing happens. The links do hiite on mouseover still though.

worksforme, however this could be related to your prefs.. do you have it set to single or double click?

Yes, this appears very broken. I am also using 031009 (Friday morning) commercial release build and I see this. I don't even know where you set single vs. double clicking (can you on a release build?) but I can click 100 times and not get anything to load. I don't have any problems with other similar items in the sidebar, such as bookmars, what's related, etc. This is on a brand new, default profile on win95. I do see a that they change to a cool blue link as you mouse over them, however :-)

this appears to be an entirely different defect. reclosing, filing a new bug.

damn actually you're right.. there is a click problem here. reopening, got branch tree and a fix.

check that puppy in.

Woo hoo! It's in!

Thanks!!!

this looks good to me, will let claudius mark verified - I filed a new bug on the problem where launching search results from the sidebar can go to invalid search.netscape.com URL's

single-clicking results is working jsut fine on all builds 20000313 and forward, all platforms. VERIFIED.