Closed Bug 281139 Opened 20 years ago Closed 19 years ago

crash doing onfocus="alert()" and Reloading [@ nsEventStateManager::PreHandleEvent]

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: MatsPalmgren_bugz, Assigned: smaug)

References

Details

(4 keywords)

Crash Data

Attachments

(3 files)

Testcase
(deleted), text/html
Details
Crash data
(deleted), text/plain
Details
proposed patch
(deleted), patch
bzbarsky
: review+
bzbarsky
: superreview+
bzbarsky
: approval-branch-1.8.1+
dveditz
: approval1.8.0.5+
Details | Diff | Splinter Review
crash doing onfocus="alert()" and Reloading. There are a few earlier crash bugs on nsEventStateManager::PreHandleEvent, but none of them seemed like a dupe. STEPS TO REPRODUCE: 1. load attached testcase 2. click the button in the page 3. when the alert pops up, hold CTRL+R down and then click OK a few times 100% reproducable in a Linux debug build of todays date. I was NOT able to crash 2005-02-02-05 trunk Linux, but I'm guessing it could crash for someone else, perhaps on a slower computer or different OS.
Attached file Testcase (deleted) —
Attached file Crash data (deleted) —
Severity: major → critical
OS: Linux → All
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050213 crash OS -> All
See also bug 225302 and bug 105129.
So the problem there is that the presshell is already destroyed, right?
Keywords: helpwanted
Attached patch proposed patch (deleted) — — Splinter Review
Assignee: events → smaug
Status: NEW → ASSIGNED
Attachment #209621 - Flags: superreview?(bzbarsky)
Attachment #209621 - Flags: review?(bzbarsky)
Attachment #209621 - Flags: superreview?(bzbarsky)
Attachment #209621 - Flags: superreview+
Attachment #209621 - Flags: review?(bzbarsky)
Attachment #209621 - Flags: review+
*** Bug 324562 has been marked as a duplicate of this bug. ***
Checking in nsEventStateManager.cpp; /cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v <-- nsEventStateManager.cpp new revision: 1.632; previous revision: 1.631 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Blocks: 267286
smaug, how do you feel about this patch for branches? Is it safe? If so, we probably want it.
Flags: blocking1.8.1?
Flags: blocking1.8.0.5?
I thought it is safe, but there is Bug 336582 (which I haven't been able to reproduce)
Depends on: 336582
No longer depends on: 336582
Comment on attachment 209621 [details] [diff] [review] proposed patch This didn't cause Bug 336582. So asking approval for branches. Should be safe crash fix.
Attachment #209621 - Flags: approval1.8.0.5?
Attachment #209621 - Flags: approval-branch-1.8.1?
Attachment #209621 - Flags: approval-branch-1.8.1? → approval-branch-1.8.1?(bzbarsky)
Attachment #209621 - Flags: approval-branch-1.8.1?(bzbarsky) → approval-branch-1.8.1+
Flags: blocking1.8.1?
Keywords: helpwanted → fixed1.8.1
Flags: blocking1.8.0.5? → blocking1.8.0.5+
Comment on attachment 209621 [details] [diff] [review] proposed patch approved for 1.8.0 branch, a=dveditz for drivers
Attachment #209621 - Flags: approval1.8.0.5? → approval1.8.0.5+
Keywords: fixed1.8.0.5
verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5) Gecko/20060620 Firefox/1.5.0.5
Status: RESOLVED → VERIFIED
*** Bug 345545 has been marked as a duplicate of this bug. ***
Crash Signature: [@ nsEventStateManager::PreHandleEvent]
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: