Closed
Bug 281470
Opened 20 years ago
Closed 20 years ago
Vertical mouse drags are reversed on Google maps
Categories
(Camino Graveyard :: Page Layout, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Camino0.9
People
(Reporter: sfraser_bugs, Assigned: sfraser_bugs)
References
()
Details
(Keywords: fixed1.7.6, verified1.7.6)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Go to Google maps, and wait for the US map to load. Now click on the map, and
drag side-to-side, and note that it behaves as you expect.
Now drag up and down. Note that the movement is in the opposite direction to
your mouse movement. This does not occur in Firefox.
We must be passing Core Graphics-style mouse coords down into Gecko in the Cocoa
widget layer.
|
||
Comment 1•20 years ago
|
||
yup, saw that last night, had the same thought.
Status: NEW → ASSIGNED
Target Milestone: --- → Camino0.9
|
Assignee | |
Comment 2•20 years ago
|
||
This patch fixses the bug, and does some other cleanup in nsChildView --
removal of unused function, removal of pre-10.2 stuff, and some minor logic
cleanup.
Attachment #173748 -
Flags: review?(pinkerton)
|
|
||
Comment 4•20 years ago
|
||
+ {
+ req->GetInterface(NS_GET_IID(nsIScrollableView), (void**)&scrollableView);
+ if (scrollableView)
+ break;
+ }
why do this? the current way is just as clear.
can you make a patch that doesn't do any api clean up for the 083 branch?
r=pink
|
|
Assignee | |
Comment 5•20 years ago
|
||
|
|
Assignee | |
Comment 6•20 years ago
|
||
Comment on attachment 173748 [details] [diff] [review]
Fix WidgetToScreen and ScreenToWidget to flip coords
Checked into the trunk.
Attachment #173748 -
Attachment is obsolete: true
Attachment #173748 -
Flags: review?(pinkerton) → review+
|
|
Assignee | |
Comment 7•20 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•20 years ago
|
||
landed on branch.
Might this have also fixed Bug 237788, I wonder? (It rang a bell when I saw it.)
|
|
Assignee | |
Comment 10•20 years ago
|
||
Bug 237788 has a nice testcase.
|
|
||
Updated•20 years ago
|
Keywords: fixed1.7.6
|
||
Comment 11•20 years ago
|
||
verified fixed using 20050212-0.8.3 branch and 2005031008-trunk camino bits.
dragging behaves sensibly now.
changing "fixed1.7.6" to "verified1.7.6" since I tested with the camino branch.
Status: RESOLVED → VERIFIED
Keywords: fixed1.7.6 → verified1.7.6
|
|
||
Comment 12•20 years ago
|
||
mistakenly removed fixed1.7.6 --pardon the bugspam. set your filter/quicksearch
to "ZippidityDooDahHey" to catch these for easy removal/etc/
Keywords: fixed1.7.6
You need to log in
before you can comment on or make changes to this bug.
Description
•