RelationSet is confusing, and I don't think it will be easy to make it modern, modular Bugzilla code. It was helpful once upon a time, but we don't really depend on it anymore. We should factor it out of modern Bugzilla code, and then remove it. The diff_arrays function in bug 281550 should be very helpful in many of the cases where we wanted to use RelationSet.

For reference, here are all the places currently using RelationSet, from a quick grep: Bugzilla/Bug.pm:use Bugzilla::RelationSet; Bugzilla/Bug.pm: my $ccSet = new Bugzilla::RelationSet; Bugzilla/BugMail.pm:use Bugzilla::RelationSet; Bugzilla/BugMail.pm: my $ccSet = new Bugzilla::RelationSet(); globals.pl:use Bugzilla::RelationSet; process_bug.cgi:use Bugzilla::RelationSet; userprefs.cgi:use Bugzilla::RelationSet; userprefs.cgi: my $watcheduserSet = new Bugzilla::RelationSet; userprefs.cgi: my $origWatchedUsers = new Bugzilla::RelationSet; userprefs.cgi: my $newWatchedUsers = new Bugzilla::RelationSet($cgi->param('watchedusers'));

OK, all the dependencies have patches awaiting review. Once they are complete and checked-in, RelationSet just needs to be removed from the repo. :-) My, how simple that was. :-)

This has no patch, because it only requires RelationSet being moved to the attic, and I don't know how to do that in a patch. Once bug 281550 lands, this can be done.

BAM! Removing Bugzilla/RelationSet.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/RelationSet.pm,v <-- RelationSet.pm new revision: delete; previous revision: 1.10 done