Closed Bug 281736 Opened 20 years ago Closed 18 years ago

No database being available results in an internal server error

Categories

(Bugzilla :: Attachments & Requests, defect)

2.19.1
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 168366

People

(Reporter: cso, Unassigned)

References

()

Details

justdave restarted the database on BMO tonight, just as I was trying to load the URL above. This resulted in an Internal Server Error rather than a Bugzilla Error, which would probably be best.
Hrm. I think that the Bugzilla::DB enhancements that we're working on in bug 237862 will help, here, maybe. I'm assuming that this doesn't only happen on the attachments screen, so I'm changing the summary. :-)
Depends on: bz-dbcompat
OS: Windows XP → All
Hardware: PC → All
Summary: Trying to edit an attachment when no database is available results in an internal server error → No database being available results in an internal server error
I would guess that the DB layer will not help here. What I assume is happening is that one of the SendSQL or $dbh->execute calls fails with exception. We don't do any error checking there (and it would clutter the code a lot if we did), but the DBI error catching is turned on. So I expect when error happens, DBI spits error to stderr (i.e. system log) and exits with error (thus causing internal error page to show up). There is a DBI errror handler in the Bugzilla/DB.pm module, but currently it only trims the error message to reasonable length. We should probably modify it to call ThrowCodeError (or maybe even new ThrowDBError or so) to create meaningful error page. Problem is that we may already created part of the page at that moment, so it needs to be done carefuly to get correct html at all times...
*** This bug has been marked as a duplicate of 168366 ***
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.