Closed
Bug 283063
Opened 20 years ago
Closed 20 years ago
leak domwindows when opening and closing tabs due to browser binding's focusedWindow member
Categories
(Firefox :: Tabbed Browser, defect, P1)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox1.5
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: memory-leak, Whiteboard: [patch])
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
When opening and closing tabs, the DOMWINDOW numbers don't go down until the parent window is closed. This is a leak that's freed when the containing window is closed (rather than never freed). One of the reasons for this (I think there are also some issues with the browser:purge-session-history observers that I'll file as a separate bug once I figure out what's going on a little better) is that the focusedWindow member of the browser binding (which necessarily stays around until the parent window closes, due to nsDocument::AddReference) is not nulled out. Patch coming
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [patch]
Target Milestone: --- → Firefox1.1
Assignee | ||
Comment 2•20 years ago
|
||
I'll add the "so we force a cleanup ourselves" back. That was inadvertently dropped.
Comment 3•20 years ago
|
||
Comment on attachment 175065 [details] [diff] [review] patch r=me, with the comment restored as noted
Attachment #175065 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 4•20 years ago
|
||
Fix checked in to trunk, 2005-02-21 14:50 -0800.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•