Closed
Bug 283182
Opened 20 years ago
Closed 18 years ago
sync xpfe tabbox with toolkit tabbox
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
People
(Reporter: csthomas, Assigned: csthomas)
References
(Depends on 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [cst: try an overlay for new tab button])
Attachments
(2 files, 4 obsolete files)
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•20 years ago
|
||
I attached a patch to bug 282178: attachment 175159 [details] [diff] [review] - it should do nothing for
Seamonkey, but helps sync up the bindings.
Bug 102831 removes another difference. At that point, only the new tab button
will differ.
Depends on: 102831
Assignee | ||
Comment 2•20 years ago
|
||
(In reply to comment #1)
> I attached a patch to bug 282178: attachment 175159 [details] [diff] [review] [edit] - it should do
nothing for
> Seamonkey, but helps sync up the bindings.
>
> Bug 102831 removes another difference. At that point, only the new tab button
> will differ.
Great, I just attached two more patches to bug 282178 instead of this bug. Sorry :(
Assignee | ||
Comment 3•20 years ago
|
||
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/toolkit/content/widgets&command=DIFF_FRAMESET&file=tabbox.xml&rev2=1.20&rev1=1.19
(nothing this toolkit-only change so I don't forget about it)
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Status: ASSIGNED → NEW
Keywords: helpwanted
Comment 4•20 years ago
|
||
(In reply to comment #1)
> Bug 102831 removes another difference. At that point, only the new tab button
> will differ.
Chris,
Shouldn't that bug block bug 282178 rather than the current one ?
*****
The |xul:stack| in
{{
<binding id="tabs-closebutton"
extends="chrome://global/content/bindings/tabbox.xml#tabs">
<content>
<xul:stack>
<xul:spacer class="tabs-left"/>
<xul:toolbarbutton ondblclick="event.preventBubble();"
class="tabs-newbutton"
xbl:inherits="oncommand=onnewtab,tooltiptext=tooltiptextnew"/>
</xul:stack>
}}
has never been in the Toolkit version:
{{
1.1 hyatt%netscape.com 2002-08-10 01:49 Removing New Tab button.
}}
Comment 5•20 years ago
|
||
Clears the way to better see the 3 remaining sync to do.
Updated•20 years ago
|
Attachment #178034 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #178034 -
Flags: review?(mconnor)
Assignee | ||
Updated•19 years ago
|
Whiteboard: [cst: try an overlay for new tab button]
Comment 6•19 years ago
|
||
Comment on attachment 178034 [details] [diff] [review]
(Av1) <tabbox.js> (nits on both files)
rs=me
Attachment #178034 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 7•19 years ago
|
||
Comment on attachment 178034 [details] [diff] [review]
(Av1) <tabbox.js> (nits on both files)
This patch doesn't need SR.
Attachment #178034 -
Flags: superreview?(neil.parkwaycc.co.uk) → review?(neil.parkwaycc.co.uk)
Comment 8•19 years ago
|
||
Av1, updated to current Trunk,
with more nits and a "warning" fix.
Attachment #178034 -
Attachment is obsolete: true
Attachment #208031 -
Flags: review?
Attachment #178034 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•19 years ago
|
Attachment #208031 -
Flags: review?(neil.parkwaycc.co.uk)
Attachment #208031 -
Flags: review?(mconnor)
Attachment #208031 -
Flags: review?
Updated•19 years ago
|
Attachment #208031 -
Flags: review?(neil) → review+
Comment 9•18 years ago
|
||
Av2, SM part, updated to current Trunk.
Keeping
{{
(Av2) <tabbox.js> (nits on both files)
neil: review+
}}
Attachment #208031 -
Attachment is obsolete: true
Attachment #256289 -
Flags: superreview?(neil)
Attachment #256289 -
Flags: review+
Attachment #208031 -
Flags: review?(mconnor)
Comment 10•18 years ago
|
||
Av2, TK part, updated to current Trunk.
Attachment #256290 -
Flags: review?(mano)
Comment 11•18 years ago
|
||
Av3-SM, updated to current Trunk:
there are more of them (now).
Attachment #256289 -
Attachment is obsolete: true
Attachment #256292 -
Flags: superreview?(neil)
Attachment #256292 -
Flags: review?(neil)
Attachment #256289 -
Flags: superreview?(neil)
Comment 12•18 years ago
|
||
Av3-TK, updated to current Trunk:
there is one more (now).
Attachment #256290 -
Attachment is obsolete: true
Attachment #256294 -
Flags: review?(mano)
Attachment #256290 -
Flags: review?(mano)
Comment 13•18 years ago
|
||
Hmm... shouldn't we change this to document.activeElement (which is safer)?
Comment 14•18 years ago
|
||
Comment on attachment 256294 [details] [diff] [review]
(Av4-TK) <tabbox.js> (nits)
[Checkin: Comment 15]
r=mano
Attachment #256294 -
Flags: review?(mano) → review+
Comment 15•18 years ago
|
||
Comment on attachment 256294 [details] [diff] [review]
(Av4-TK) <tabbox.js> (nits)
[Checkin: Comment 15]
Checkin: {
2007-02-25 08:52 bugzilla%standard8.demon.co.uk mozilla/toolkit/content/widgets/tabbox.xml 1.41
}
Attachment #256294 -
Attachment description: (Av4-TK) <tabbox.js> (nits) → (Av4-TK) <tabbox.js> (nits)
[Checkin: Comment 15]
Updated•18 years ago
|
Attachment #256292 -
Flags: superreview?(neil)
Attachment #256292 -
Flags: superreview+
Attachment #256292 -
Flags: review?(neil)
Attachment #256292 -
Flags: review+
Updated•18 years ago
|
Whiteboard: [cst: try an overlay for new tab button] → [checkin needed: Av4-XPFE] [cst: try an overlay for new tab button]
Comment 16•18 years ago
|
||
Comment on attachment 256292 [details] [diff] [review]
(Av4-XPFE) <tabbox.js> (nits)
[Checkin: Comment 16]
Checkin: {
2007-03-08 10:44 bugzilla%standard8.demon.co.uk mozilla/xpfe/global/resources/content/bindings/tabbox.xml 1.49
}
Attachment #256292 -
Attachment description: (Av4-XPFE) <tabbox.js> (nits) → (Av4-XPFE) <tabbox.js> (nits)
[Checkin: Comment 16]
Updated•18 years ago
|
Whiteboard: [checkin needed: Av4-XPFE] [cst: try an overlay for new tab button] → [cst: try an overlay for new tab button]
Comment 17•18 years ago
|
||
SeaMonkey is using toolkit now, is there still anything we need to port from xpfe tabbox to toolkit or can we close this bug?
Comment 18•18 years ago
|
||
IIRC XPFE tabbox.xml has nothing new.
Comment 19•18 years ago
|
||
in this case, I'm marking the bug as fixed (due to it containing fixes that have been checked in). Please reopen or file new bugs if we run across something unexpected we still would need to port to toolkit.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•