audit issues: unchecked allocs => don't crash (or leak) leaking on oom => don't leak :) else after return/return after else => drop the else and fix the indentation ns_assertion(0,...) => use ns_error

hrm, to be clear, for return after else, you need to negate the if condition, promote the return and then unindent the main block. if (foo) { statement; statement; } else return blah; => if (!foo) return blah; statement; statement;

Gandalf, still working on this? (file in question is at: http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgDBView.cpp )

didn't touch it in 4 years, so feel free to takeover. :)

perhaps also bug 456332 and bug 460036? If so, this is likely also causing topcrashes

(In reply to comment #0) > ns_assertion(0,...) => use ns_error More global issue, moved to bug 489505.

(In reply to comment #0) > audit issues: > 1. unchecked allocs => don't crash (or leak) > 2. leaking on oom => don't leak :) > 3. else after return/return after else => drop the else and fix the indentation > 4. ns_assertion(0,...) => use ns_error Is there anything here left to do? I skimmed the source and it looks like 1,3,4 are done. I this also done? > leaking on oom => don't leak :)

(In reply to comment #6) > I this also done? > > leaking on oom => don't leak :) The mozilla codebase has been moving to an abort-on-oom for failure, so out-of-memory should just cause the program to crash instead of merely leaking...

Resolve WFM then. :)