Closed
Bug 284058
Opened 20 years ago
Closed 18 years ago
Changing signature-placement preference won't save
Categories
(Thunderbird :: Preferences, defect)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird2.0
People
(Reporter: yanush, Assigned: mscott)
References
Details
(Keywords: fixed1.8.1, verified1.8.1.3)
Attachments
(1 file)
(deleted),
patch
|
mscott
:
review+
mscott
:
approval-thunderbird2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050212 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050212 Firefox/1.0+
currently my identity settings of composition & addressing shows "place my
signature below the quote (recommended)". after changing it to "below my reply
(above the quote)" and saving, Tbird won't save this action.
Reproducible: Always
Steps to Reproduce:
1. tools - account settings
2. mark one of your acounts and press manage identities
3. edit your identity
4. composition & addressing
5. mark automatically quote the original message when replying
6. Then, "Start my reply above the quote"
7. and place my signature "below my reply (above the quote)"
8. press ok (3 times)
Actual Results:
notice that the change i wated to preform wasn't saved.
Expected Results:
the change should be saved (or at least let me know why it wouldn't)
Comment 1•20 years ago
|
||
*** Bug 284059 has been marked as a duplicate of this bug. ***
Comment 2•20 years ago
|
||
I attempted to reproduce this, but I've run into bug 277187.
Yanush -- does the problem happen when editing the preference from the Account
Setting's Composition page (for the account's default identity), or only if you
go into the Manage Identities dialog?
Summary: placing a signature below my reply won't work → Changing signature-placement preference won't save
(In reply to comment #2)
> I attempted to reproduce this, but I've run into bug 277187.
>
> Yanush -- does the problem happen when editing the preference from the Account
> Setting's Composition page (for the account's default identity), or only if you
> go into the Manage Identities dialog?
Hmmm... well, i kind of missed the "composition & addressing" account dialog,
cause it worx from there (thanks!). The only place it didn't work is the "manage
identities" dialog.
Comment 4•20 years ago
|
||
Do you have multiple identities or just the one? If multiple, were the changes
that weren't being saved being made to the default identity or one of the
others?
i have 4 email accounts and only 1 identity per account.
only changing it from the main "account settings" dialog works.
a weird thing is when using the manage itentities button, it would only save the
change if it was made from "below my reply" to "below my quote" (and not vise
versa).
Comment 7•20 years ago
|
||
I can confirm this bug. I have one account and two identities. The "and place
my signature" dropdown when choosing it from the "Manage Identities" area does
not seem to retain it's selection. There does not seem to be a workaround for
those having a single account but using multiple identities.
(In reply to comment #4)
> Do you have multiple identities or just the one? If multiple, were the
changes
> that weren't being saved being made to the default identity or one of the
> others?
Comment 8•20 years ago
|
||
OK, I've confirmed this: if you change either of the two dropdowns specifying
quote/sig placement *for the default (or only) identity* via the Manage
Identities button, those changes do not persist. It seems all the other changes
made for the default identity in Manage Identites percolate up to the parallel
pages in Account Settings, as soon as Manage Identities is closed.
I do not see this problem when making a change to secondary identity.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 10•19 years ago
|
||
I can confirm this with version 1.5 (20051201).
At mine, the only thing which isn't updated, is the signature placement of the second identity.
Comment 11•19 years ago
|
||
This is the quickfix for this bug (and this might help the dev. team to fix the code):
Open the prefs.js file in any text editor (I used notepad) and search this string :
user_pref("mail.identity.id1.sig_bottom", true);
ATTENTION!!! The "id" number will vary if you use more than one identity.
Change the value to false. Issue is fixed!
Comment 12•19 years ago
|
||
Hmm i dont seem to have the string in my prefs.js file. I actually dont have any strings other than a remark about not changing things in this file while the browser is open :)
Maybe i got the wrong file ?
I found my file in the "Mozilla Thunderbird\defaults\profile" folder.
Comment 13•19 years ago
|
||
if you're using 1.5, you can use the config editor, tools | options | advanced | config editor. Otherwise, prefs.js is in your user profile directory, on windows, c:\documents and settings\<user name>\application data\thunderbird\profiles\<profile>
Comment 14•19 years ago
|
||
(In reply to comment #12)
> Hmm i dont seem to have the string in my prefs.js file. I actually dont have
> any strings other than a remark about not changing things in this file while
> the browser is open :)
>
If the line doesn't exist, you can simply add it!
Comment 15•19 years ago
|
||
cool enough .. it worked ...
but know if i reply a message and change the signature it dosent remove the old signature ?!?!?!
But it works better than before .. :|
Comment 16•19 years ago
|
||
xref bug 278453
Comment 17•19 years ago
|
||
*** Bug 337283 has been marked as a duplicate of this bug. ***
Attachment #177145 -
Flags: review?(mscott)
Assignee | ||
Comment 18•18 years ago
|
||
I'm able to reproduce this. I haven't tried it with the patch though.
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird2.0
Assignee | ||
Comment 19•18 years ago
|
||
Comment on attachment 177145 [details] [diff] [review]
[fixed on the branch and the trunk] patch
This patch didn't fix the problem for me. But by the looks of it, it should. Odd.
Assignee | ||
Comment 20•18 years ago
|
||
Comment on attachment 177145 [details] [diff] [review]
[fixed on the branch and the trunk] patch
this patch didn't fix the problem for me, but it is correct and should be checked in.
Attachment #177145 -
Flags: review?(mscott)
Attachment #177145 -
Flags: review+
Attachment #177145 -
Flags: approval-thunderbird2+
Assignee | ||
Comment 21•18 years ago
|
||
Comment on attachment 177145 [details] [diff] [review]
[fixed on the branch and the trunk] patch
I landed this patch on the trunk and the branch, but will leave the bug open since it didn't seem to fix the problem (at least for me)
Attachment #177145 -
Attachment description: patch → [fixed on the branch and the trunk] patch
Assignee | ||
Comment 22•18 years ago
|
||
is this working for anyone now that this patch has been checked in?
Comment 23•18 years ago
|
||
Yes, the symptom I describe in comment 8 appears to have been fixed.
TB 2a1-0724 , Win2K.
Comment 24•18 years ago
|
||
*** Bug 349537 has been marked as a duplicate of this bug. ***
Comment 25•18 years ago
|
||
Im sorry i would like to test the new patch but i dont know how to aply the patch ? Can you guys please help me... :)
Assignee | ||
Comment 26•18 years ago
|
||
closing out per mcow's verification comments.
Comment 27•18 years ago
|
||
verified fixed 1.8.1.3 with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 using the steps to reproduce from comment #0
Keywords: verified1.8.1.3
Comment 28•17 years ago
|
||
I'm still having this problem.
Thunderbird version 2.0.0.6 (20070728)
Windows 2000
Comment 29•17 years ago
|
||
I have this problem too. Versie 2.0.0.6 (20070728) nl on WinXP SP2.
Changing the settings for all identities works if I have not selected the default value (below the quoted text) and want to change to default. If currently the setting is putting the signature below it is impossible to change this via the UI.
Comment 30•17 years ago
|
||
This issue persists.
Thunderbird version 2.0.0.9 (20071031)
Mac OS X Version 10.4.11, Build 8S2167
You need to log in
before you can comment on or make changes to this bug.
Description
•