Closed
Bug 284081
Opened 20 years ago
Closed 20 years ago
When software install (xpinstall.enabled) is disabled clicking "Edit Options" on the message bar opens an empty window
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
Firefox1.5
People
(Reporter: me, Assigned: steffen.wilberg)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mconnor
:
review+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
When you have software install disabled, the message bar popups up giving you
the option to re-enable it, but with the new options window that doesn't work.
This bug is similar to Bug 283944 but is not the same.
Steps to reproduce:
1. Goto Tools->Options->Content
2. Uncheck "Allow web sites to install software"
3. Try to install something, e.g. http://hacksrus.com/~ginda/chatzilla/
4. Click "Edit Options"
Actual Results
An empty window opens.
Expected Results
The options window opens at the Content page (or some other method of
re-enabling software install is provided).
p.s. This is *not* a dupe of Bug 283944, note step 2 above.
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050228 Firefox/1.0+
*** Bug 287117 has been marked as a duplicate of this bug. ***
Tweaking summary (added pref name, xpinstall.enabled) to make bug more findable.
Based on dupe:
OS -> ALL
OS: other → All
Summary: When software install is disabled clicking "Edit Options" on the message bar opens an empty window → When software install (xpinstall.enabled) is disabled clicking "Edit Options" on the message bar opens an empty window
Updated•20 years ago
|
Flags: blocking-aviary1.1? → blocking-aviary1.1+
Assignee | ||
Comment 3•20 years ago
|
||
Mostly done, but I need to update the pane button when the dialog is already
open and we're just switching the pane.
Assignee: bugs → steffen.wilberg
Status: NEW → ASSIGNED
Comment 4•20 years ago
|
||
*** Bug 287890 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 5•20 years ago
|
||
Now it flies. Use e.g. openPreferences("paneContent"); to open the Content
pane. The pane button is now selected in the showPane method.
Tested in Thunderbird as well. It doesn't break it, but Thunderbird needs a
port of the openPreferences() changes to its openOptionsDialog() function in
mailCore.js and adjust the callers of that.
Attachment #180428 -
Attachment is obsolete: true
Attachment #180784 -
Flags: review?(mconnor)
Comment 6•20 years ago
|
||
Comment on attachment 180784 [details] [diff] [review]
patch v1
let's try to get this for alpha, not hold-worthy at this stage though.
Attachment #180784 -
Flags: review?(mconnor)
Attachment #180784 -
Flags: review+
Attachment #180784 -
Flags: approval-aviary1.1a?
Comment 7•20 years ago
|
||
Comment on attachment 180784 [details] [diff] [review]
patch v1
a=asa
Attachment #180784 -
Flags: approval-aviary1.1a? → approval-aviary1.1a+
Assignee | ||
Comment 8•20 years ago
|
||
Checking in mozilla/browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js
new revision: 1.422; previous revision: 1.421
done
Checking in mozilla/browser/base/content/utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v <-- utilityOverlay.js
new revision: 1.20; previous revision: 1.19
done
Checking in mozilla/toolkit/content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v <-- preferences.xml
new revision: 1.14; previous revision: 1.13
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.1
Comment 9•20 years ago
|
||
I believe this caused Bug 292411
Comment 10•18 years ago
|
||
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in
before you can comment on or make changes to this bug.
Description
•