Closed Bug 284166 Opened 20 years ago Closed 20 years ago

[FIX]Shadow image not updated during image resizing, causing paint artefacts

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.8beta2

People

(Reporter: martijn.martijn, Assigned: bzbarsky)

References

()

Details

(Keywords: regression, testcase)

Attachments

(2 files)

The testcase comes from bug 253078. When resizing the image, the shadow image (the image that's half transparent and which functions as a hint of what the final image's size should be) is not getting updated, so I'm getting screen artefacts when I'm busy with resizing. After finishing with resizing, everything looks all right. This works in a 20040520 trunk build. This doesn't work in a 20040522 trunk build. http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-05-20+13%3A00%3A00&maxdate=2004-05-22+10%3A00%3A00&cvsroot=%2Fcvsroot I guess this could be a regression from the fix for bug 243882.
Yep, backing out the fix for bug 243882 fixes this bug in my debug build.
Blocks: 243882
So what is this "shadow image" thing? Where is it drawn? Whatever code is drawing it is buggy, per bug 243882 comment 0... Also, I only see the problem when resizing horizontally or vertically. When I resize diagonally, things look fine. Is that what you see? Finally, could you file a bug on the resize handles being mis-positioned?
Attached file Testcase, no editor involved. (deleted) —
It looks like resizing of absolutely positioned images in fact does _not_ invalidate the right area...
Assignee: mozeditor → jdunn
Component: Editor → Layout: Images
OS: Windows XP → All
QA Contact: bugzilla → layout.images
Hardware: PC → All
Attached patch Fix (deleted) — Splinter Review
This makes sure to invalidate the rect of the image if it's actually been resized.
Assignee: jdunn → bzbarsky
Status: NEW → ASSIGNED
Attachment #175897 - Flags: superreview?(roc)
Attachment #175897 - Flags: review?(roc)
Oh, and nice catch. ;)
Priority: -- → P1
Summary: Shadow image not updated during image resizing, causing paint artefacts → [FIX]Shadow image not updated during image resizing, causing paint artefacts
Target Milestone: --- → mozilla1.8beta2
Attachment #175897 - Flags: superreview?(roc)
Attachment #175897 - Flags: superreview+
Attachment #175897 - Flags: review?(roc)
Attachment #175897 - Flags: review+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Yes, I was a bit vague here. I hadn't that much time and had a bit more bugs to file. For some (odd) reason I was in a hurry to file this one (and didn't bother to write a proper testcase). (In reply to comment #2) > Finally, could you file a bug on the resize handles being mis-positioned? That's bug 253078.
Status: RESOLVED → VERIFIED
Hey, the testcase you pointed to did the job! No big deal.
Product: Core → Core Graveyard
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: