User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050303 Firefox/1.0+ Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050303 Firefox/1.0+ When I go in to edit my preferences, part of the interface is cut off. The problem is easily fixed by resizing the window. However the default size of the window cuts off part of the interface in almost every tab. If I resize the window to an appropriate size and hit "Close", and then reenter the preferences window none of the tabs are cut off, except the Privacy Tab, which remains cut off every time I reopen the window, no matter what size I resize it to. Reproducible: Always Steps to Reproduce: 1. Enter Firefox 2. Go into Edit -> Preferences 3. Resize the preferences window so no tabs are cut off 4. Hit close on the Preferences window and then reenter the preferences window Actual Results: Before step three, the tabs are all cut off. After step three, the privacy tab is cut off. Expected Results: The tabs should not be cut off at any time. I am running Mandrake Linux 10.1, using Gnome as my desktop environment.

I took a quick look through the Preferences bugs, and I'm not seeing a duplicate bug, so I'm marking this NEW. However, see bug 285851 for the equivalent bug for OS/2. There might be some hints as to how to fix this there, but I haven't really looked at the code enough to tell. While this isn't a huge bug, it looks really unprofessional and should definitely be fixed for 1.1.

This should fix the problem.

Is this still a problem in the new prefs window?

I think it still is. I downloaded the latest nightly and attached is a screenshot of the problem still occuring. I'm using a different system than when I first reported the bug, however, I am now using Gentoo Linux and a newer version of Gnome. I was using: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050409 Firefox/1.0+

I just wanted to confirm this under Windows as well. It occurs when you have changed your default window font to one that is larger (wider?) than the OS default. Courier and Fixed(sys) under Gnome and WinXP, for example. This text overflow occurs in several places, such as the download manager, and certificate viewer. Considering that Secunia reported the text overflow in the DL manager as a critical risk a while ago, this might deserve more attention eventually, even though few people change their entire OS font under Windows.

The patch is wrong, you should instead modify this: http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/preferences/preferences.dtd#4 .. but that'd still be wrong, as it won't work on some other system with weird settings.

Comment on attachment 177609 [details] [diff] [review] Patch to preferences.xul hardcoding this in pixels is bad, since we can't adapt to font sizes this way...

*** Bug 297010 has been marked as a duplicate of this bug. ***

I might be able to provide more explanation. I am using Deer Park Alpha 2 (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050712 Firefox/1.0+) The dialog correctly sizes itself for the first tab in the dialog. If you switch to another tab with more controls then it is too small. Reproducible: Always Steps to Reproduce: 1. Enter Firefox 2. Go into Edit -> Preferences 4. Change tab to Privacy (which needs the most space). Actual Results: When you open the dialog it is sized perfectly for the tab you last used (initially the General Tab). When you change to a tab that needs more space not all the controls fit in the dialog and you have to resize it. Expected Results: When you open the dialog it should automatically size itself to the size needed by the biggest tab instead of the current tab.

This fixes the issue by setting the height of the prefs. window using an em value like we do on Windows. Previously, we were just making the prefs. window whatever height it was when it was first opened (pretty small when it's focused on the General tab). So now we set it to the height of the tallest window of the prefs. and stick with that. This makes it look good with a 10 pt font (which is the default for GNOME). I played around with making it work with different sized fonts, but if I made it work with other sizes, it looked too big with 10 point sized font, and still ends up breaking with an 8 pt font, too. mconnor said that this is an issue, so there might be another bug for it. I just figured that it would be pointless to make it work for 10 and 9 if we couldn't make it work for 8 point too. I specified a UNIX width for the fonts window too. It will still mess up on 8 and 9 point system fonts though. Thanks to mconnor for pointing out the easy way to fix this to me.

*** Bug 302025 has been marked as a duplicate of this bug. ***

It seems that if the Pref window starts with the General panel, it's too short, but when it starts with e.g. Privacy, then it uses the correct width. This is what I see in my Firefox (Firefox session recorded and saved as Flash): http://beta.aviary.pl/marcoos/stuff/pref-win.htm (you may need to click 'next' in the bottom-right corner a few times, the animation stops after displaying descriptions in English and Polish) Other problem can be seen if you change Gnome's default font size to something below 10 (e.g. 8 or 9) - the windows that had correct sizes when your default font size was 10 become... to small (!). It's especially visible in locales with statistically longer words than en-US, e.g. pl-PL.

(In reply to comment #13) > It seems that if the Pref window starts with the General panel, it's too short, > but when it starts with e.g. Privacy, then it uses the correct width. I meant "width and/or height", sorry. ;-)

Comment on attachment 190493 [details] [diff] [review] sets height of prefs window to a "fixed" height and adds UNIX width for fonts.xul >Index: preferences.dtd >=================================================================== > #ifdef XP_MACOSX > style="width: &window.macWidth; !important;"> > #else >+#ifdef XP_UNIX >+ style="width: &window.unixWidth; !important;"> >+#else > style="width: &window.width; !important;"> > #endif >+#endif XP_UNIX is defined on OS X (as well as XP_MACOSX) let's do: #ifdef XP_UNIX #ifdef XP_MACOSX --mac-part-- #else --unix-part #endif #else --win-or-anything-else-part-- #endif

Comment on attachment 194695 [details] [diff] [review] update with Mano's comments addressed browser/locales/en-US/chrome/browser/preferences/preferences.dtd >=================================================================== >RCS file: /cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.dtd,v >retrieving revision 1.2 >diff -p -U8 -r1.2 preferences.dtd >--- browser/locales/en-US/chrome/browser/preferences/preferences.dtd 25 Feb 2005 09:07:46 -0000 1.2 >+++ browser/locales/en-US/chrome/browser/preferences/preferences.dtd 2 Sep 2005 20:45:53 -0000 >@@ -1,13 +1,13 @@ > > <!ENTITY prefWindow.titleWin "Options"> > <!ENTITY prefWindow.titleGNOME "&brandShortName; Preferences"> > <!ENTITY prefWindow.styleWin "width: 42em; height: 36em;"> > <!ENTITY prefWindow.styleMac "width: 47em;"> >-<!ENTITY prefWindow.styleUnix "width: 42em;"> >+<!ENTITY prefWindow.styleUnix "width: 42em; height: 34.5em;"> At this point, we can't change an entity value without changing its name too (That's, in order to make sure localizations are fixed too), let's make that (and the other one) prefWindow.styleGnome, please also update preferences.xul.

Comment on attachment 194701 [details] [diff] [review] patch with styleUnix changed to styleGNOME r=mano

Trunk: Checking in components/preferences/fonts.xul; /cvsroot/mozilla/browser/components/preferences/fonts.xul,v <-- fonts.xul new revision: 1.12; previous revision: 1.11 done Checking in components/preferences/preferences.xul; /cvsroot/mozilla/browser/components/preferences/preferences.xul,v <-- preferences.xul new revision: 1.7; previous revision: 1.6 done Checking in locales/en-US/chrome/browser/preferences/fonts.dtd; /cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/fonts.dtd,v <-- fonts.dtd new revision: 1.8; previous revision: 1.7 done Checking in locales/en-US/chrome/browser/preferences/preferences.dtd; /cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.dtd,v <-- preferences.dtd new revision: 1.3; previous revision: 1.2 done

Hmm. I tried this patch with with german chrome files and three of the words (above all the sanitize button) are still not completely visible: (branch) http://www.pryan.org/mozilla/firefox/amano/Fx-2005-09-02-DeerPark-O1-SVG-MNG-Exp-DE.exe

(In reply to comment #21) > Hmm. I tried this patch with with german chrome files and three of the words > (above all the sanitize button) are still not completely visible: These changed only applied to the default en-US localization files. They make the prefs. and font window look okay with the default font size and font on GNOME, which is what we're going for.

any chance we can see this on the branch?

This needs to be verified on the trunk before we'll consider it for the branch.

*** Bug 300277 has been marked as a duplicate of this bug. ***

verified on linux Fx trunk build 2005-09-06-06-trunk

Let's make sure Ben or Mike signs off on this before we talk about approving this for the branch.

1.8 Branch: Checking in components/preferences/fonts.xul; /cvsroot/mozilla/browser/components/preferences/fonts.xul,v <-- fonts.xul new revision: 1.11.2.1; previous revision: 1.11 done Checking in components/preferences/preferences.xul; /cvsroot/mozilla/browser/components/preferences/preferences.xul,v <-- preferences.xul new revision: 1.6.4.1; previous revision: 1.6 done Checking in locales/en-US/chrome/browser/preferences/fonts.dtd; /cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/fonts.dtd,v <-- fonts.dtd new revision: 1.7.2.1; previous revision: 1.7 done Checking in locales/en-US/chrome/browser/preferences/preferences.dtd; /cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.dtd,v <-- preferences.dtd new revision: 1.2.8.1; previous revision: 1.2 done

verified on Firefox 1.4 -mozilla1.8 branch- Linux : 2005-09-07