In an effort to speed up cross-database installation support, and actually get it complete in the time that we have, I think that we should wrap ALL the current table changes in a block that only runs if the database is MySQL, and then only table changes that come after 2.20 will have to worry about being Pg-compatible. This means that until we actually implement bz-dbinstall (that's a bug alias), PostgreSQL users should be not expect to be able to upgrade smoothly without some manual code-running.

Comment on attachment 176839 [details] [diff] [review] Wrap Upgrade Code in MySQL-specific wrapper r=glob not a big fan of the lack of indentation, but we're already do that in checksetup (BEGIN block). r+ in its current form. bonus points if you display a warning to non-mysql users.

Comment on attachment 176839 [details] [diff] [review] Wrap Upgrade Code in MySQL-specific wrapper Actually, this causes some minor problems on Pg.

Comment on attachment 176839 [details] [diff] [review] Wrap Upgrade Code in MySQL-specific wrapper Nevermind, this one is OK.

Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.370; previous revision: 1.369 done