Closed Bug 285380 Opened 20 years ago Closed 20 years ago

Bugzilla::DB::Schema uses ThrowCodeError incorrectly

Categories

(Bugzilla :: Bugzilla-General, defect, P1)

2.19.2
defect

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

This is causing Tinderbox to burn, but the patch was so huge I don't want to back it out right now. It's a very simple fix, which I will attach.
This really should be "minor," but it's making Tinderbox burn.
Assignee: general → mkanat
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.20
Attached patch Change it to a "die" (obsolete) (deleted) — Splinter Review
I just changed it to a die -- this code is called mostly at the command-line anyway.
Attachment #176815 - Flags: review?(bugzilla)
Comment on attachment 176815 [details] [diff] [review] Change it to a "die" r=glob
Attachment #176815 - Flags: review?(bugzilla) → review+
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
Checking in Bugzilla/DB/Schema.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v <-- Schema.pm new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
There are more instances of ThrowCodeError. :-(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Fix the rest of them (deleted) — Splinter Review
Attachment #176815 - Attachment is obsolete: true
Attachment #176821 - Flags: review?(justdave)
Attachment #176821 - Flags: review?(justdave) → review+
Checking in Bugzilla/DB/Schema.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v <-- Schema.pm new revision: 1.3; previous revision: 1.2 done
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: