Closed Bug 28555 Opened 25 years ago Closed 25 years ago

StyleContextImpl's leaked like crazy

Categories

(Core :: CSS Parsing and Computation, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: memory-leak, Whiteboard: 2/21: Requested verification by reporter)

Attachments

(1 file)

DESCRIPTION: StyleContextImpl's are being leaked like crazy. This is being under-reported on Tinderbox because of bug 28413 (bloat stats totals incorrect). It looks like this leak was introduced by attinasi@netscape.com on Feb 10 (was it noticed on tinderbox at all?). This leak currently accounts for roughly one half of the leaks (38K of about 70K) I see on a simple start up and shut down of Mozilla. Note that I'm not sure exactly what my leak total is, since the bloat stats are wrong. I have a fix and will attach it. I would like to get this fix reviewed and checked in to M14.
Attached patch proposed fix (deleted) — Splinter Review
Keywords: beta1, mlk
Fix checked in 2000-02-20 07:18-0800.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
When I checked this in, tinderbox's *incorrect* (see bug 28413) total fell from 75K to 58K on autobahn. However, there were really 43K of leaks fixed between the two runs (some could be the usual random variation): Leak Old New Chg nsVoidArray 784 752 32 nsStr 19500 13220 6280 nsSupportsArray 3024 1440 1584 StyleContextImpl 50344 14616 35728 TOTAL 43624
David: I do not have sufficient info to verify this fixed? Could you please mark it verified? Thanks
Whiteboard: 2/21: Requested verification by reporter
Well, I'm the one that fixed it, but I'll mark it verified since tinderbox verified it in the leak stats...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: