Closed Bug 285713 Opened 20 years ago Closed 20 years ago

Cross-DB bz_column_info and bz_index_info

Categories

(Bugzilla :: Bugzilla-General, enhancement, P1)

2.19.2
enhancement

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

We need a function like bz_get_field_def, but one that works in a cross-database-compatible way.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.20
I'm also going to do index_info, because this turns out to be really easy.
Summary: Cross-DB bz_column_info → Cross-DB bz_column_info and bz_index_info
I also renamed one Schema function so that its purpose was clearer.
Attachment #177117 - Flags: review?(Tomas.Kopal)
Attachment #177117 - Flags: review?(edwardjsabol)
Blocks: 285723
Comment on attachment 177117 [details] [diff] [review] bz_column_info and bz_index_info > #-------------------------------------------------------------------------- >+sub get_column_abstract { > >+=item C<get_column_abstract($table, $column)> >+ >+ Description: A column definition from the abstract internal schema. >+ cross-database format. >+ Params: $table - The name of the table >+ $column - The name of the column that you want >+ Returns: A hash reference. For the format, see the docs for >+ C<ABSTRACT_SCHEMA>. >+ Returns undef if the column or table does not exist. >+ >+=cut >+ >+ my ($self, $table, $column) = @_; >+ I didn't notice it before, but I don't like having the method description *inside* of the function body. I prefer to have it *before* the function header. But I suppose that should be different bug, as it is already in the code in cvs.
Attachment #177117 - Flags: review?(Tomas.Kopal) → review+
Attachment #177117 - Flags: review?(edwardjsabol)
Blocks: 285748
Flags: approval?
Flags: approval? → approval+
Yeah, I agree about the POD location. But just like you, I said, "Well, it's already done that way. Different bug." Checking in Bugzilla/DB.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v <-- DB.pm new revision: 1.36; previous revision: 1.35 done Checking in Bugzilla/DB/Schema.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v <-- Schema.pm new revision: 1.11; previous revision: 1.10 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: