There are a few in nsPrefMigration.cpp and another couple in nsProfileAccess.cpp.

Comment on attachment 177457 [details] [diff] [review] patch >+ PR_Free(folderName); nsCRT::free >+ PR_Free(folderName); ditto, and same for the next too And in all three cases cases folderName should move inside the loop.

> >+ PR_Free(folderName); > > nsCRT::free ok. FYI: http://lxr.mozilla.org/mozilla/source/xpcom/obsolete/nsFileSpec.h#290 (although I did see at least one place where nsCRT::free was used)

Was I mixing up GetLeaf and GetLeafName? Or is the comment on one of them wrong?

oh. right. sorry. it's GetLeafName, which is supposed to be used with nsCRT:free

Comment on attachment 177457 [details] [diff] [review] patch >RCS file: /cvsroot/mozilla/profile/pref-migrator/src/nsPrefMigration.cpp,v >+++ pref-migrator/src/nsPrefMigration.cpp 15 Mar 2005 06:00:06 -0000 >@@ -1482,32 +1482,29 @@ nsPrefMigration::GetSizes(nsFileSpec inp >- if (nsCStringEndsWith(fileOrDirNameStr, MAIL_SUMMARY_SUFFIX_IN_4x) || nsCStringEndsWith(fileOrDirNameStr, NEWS_SUMMARY_SUFFIX_IN_4x) || nsCStringEndsWith(fileOrDirNameStr, SUMMARY_SUFFIX_IN_5x)) /* Don't copy the summary files */ >- continue; >- else >+ if (!nsCStringEndsWith(fileOrDirNameStr, MAIL_SUMMARY_SUFFIX_IN_4x) && !nsCStringEndsWith(fileOrDirNameStr, NEWS_SUMMARY_SUFFIX_IN_4x) && !nsCStringEndsWith(fileOrDirNameStr, SUMMARY_SUFFIX_IN_5x)) /* Don't copy the summary files */ Hmm, I know you did not do the original line, but while touching it, why not adhere to the 80 char line limit?

updated to address dbaron's comments

fixed