User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.7.5) Gecko/20041217 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.7.5) Gecko/20041217 For the new skins of the first "community based suite release" an option to toggle the icon size would be great. Patch to fix this is attached. I'm using the same attribute ("iconsize") and the same values ("small" and "large") the new toolkit uses. This may perhaps make it easier to port the new skins to the new toolkit. Reproducible: Always

(In reply to comment #2) > bug 86455 At least for the "new community based suite" the bug above depends on this one. I'll create the "new modern" later as soon as this is fixed.

Comment on attachment 177975 [details] [diff] [review] Patch to get toggle functionality > // 0 = Pictures Only, 1 = Text Only, 2 = Pictures and Text > pref("browser.chrome.toolbar_style", 2); >+pref("browser.chrome.toolbar_smallicons", false); Nobody else uses these prefs, they should be moved to browser-prefs.js >+<!ENTITY useSmallIcons.label "Use Small Icons"> >+<!ENTITY useSmallIcons.accesskey "a"> > <!ENTITY showHideTooltips.label "Show Tooltips"> > <!ENTITY showHideTooltips.accesskey "t"> > <!ENTITY useSiteIcons.label "Show Web Site Icons"> > <!ENTITY useSiteIcons.accesskey "i"> > <!ENTITY enableAutomaticImageResizing.label "Resize large images to fit in the browser window"> > <!ENTITY enableAutomaticImageResizing.accesskey "R"> > <!ENTITY useSmoothScroll.label "Use smooth scrolling"> > <!ENTITY useSmoothScroll.accesskey "s"> "U" is free, I think. ("t" should be "T" and "i" should be "I" and "s" should be "S" and "smooth scrolling" should be "Smooth Scrolling") >+ var style; Spaces only, no tabs please. >+ style = this.prefs.getBoolPref(name) ? "small" : "large"; Should be "small" or null, I think, as null is the default. >+ this.observe(this.prefs, "nsPref:changed", this.domain_iconsize); You need to wrap this in an if too, otherwise you'll adversely affect the performance tests. Don't you need to update themes/modern/global/globalBindings.xml?

(In reply to comment #4) > Nobody else uses these prefs, they should be moved to browser-prefs.js I'll change that. Thanks > "U" is free, I think. ("t" should be "T" and "i" should be "I" and "s" should > be "S" and "smooth scrolling" should be "Smooth Scrolling") Means you would prefer "U". OK... > >+ this.observe(this.prefs, "nsPref:changed", this.domain_iconsize); > You need to wrap this in an if too, otherwise you'll adversely affect the > performance tests. But that would mean that the attribute isn't set on startup... It is set in firefox. How do they do that there? > Don't you need to update themes/modern/global/globalBindings.xml? Yes. I have to do many more things to get this working with modern (for example adding small icons). Maybe it's better to change globalBindings.xml as soon as I have all the changes done in modern.

IMO this one should be checked in first. We don't need to update toolbarbuttons.xml as the "new toolkit way" to get the property is: toolbar[iconsize="small"] #back-button:active { foobar = "foo"; }

IMO this one should be checked in as soon as our skins that get shipped with the "Community Suite" support the features that we don't confuse users with an "non functional" checkbox.

(In reply to comment #6) >the "new toolkit way" to get the property is: > >toolbar[iconsize="small"] #back-button:active { > foobar = "foo"; >} "The use of the descendant selector is banned in UI CSS" - quoted out of context from http://www.mozilla.org/xpfe/goodcss.html but there's lots of good stuff in there which I think our current themes get wrong :-(

But the themes for the new toolkit use this, so perhaps we should use it, too if we don't plan to rewrite the whole toolkit?

Comment on attachment 178460 [details] [diff] [review] Backend patch for this feature >+pref("browser.chrome.toolbar_smallicons", false); The toolbar_style pref should move here too, nobody else uses it. > <parameter name="tag"/> >+ <parameter name="attrib"/> > <parameter name="style"/> Might as well rename all your style variables to value as they're not really a style any more.

Manuel, are you still trying to work on this, with us changing to toolkit, your new icon set, etc.?

Filter "spam" on "guifeatures-nobody-20080610".

This was fixed as part of bug 394288 and therefore duplicates a part of that other bug.