Closed
Bug 286936
Opened 20 years ago
Closed 17 years ago
Move keyword ID retrieval (based on keyword name) in .pm (and out of editkeywords.cgi web interface)
Categories
(Bugzilla :: Administration, task)
Bugzilla
Administration
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: goobix, Assigned: mkanat)
References
Details
(Whiteboard: [blocker will fix])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/plain
|
Details |
|
Reporter | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Summary: Move keyword name validation inside Bugzilla::Keyword.pm → Move keyword ID retrieval (based on keyword name) in .pm (and out of editkeywords.cgi web interface)
|
|
Reporter | |
Comment 1•20 years ago
|
||
Attachment #178055 -
Flags: review?(mkanat)
|
Assignee | |
Comment 2•20 years ago
|
||
Comment on attachment 178055 [details] [diff] [review]
v1
Hrm, I want to discuss this a little bit, before granting review.
Why have a Bugzilla::Keyword? Why not put this in Bugzilla::Bug? And also, even
if we do have a Bugzilla::Keyword, should it be Bugzilla::Bug::Keyword?
I'm not saying that any of these are correct, just asking for your thoughts on
the subject.
Oh, also, no need for the $query var, it can just be put directly into the
prepare statement. In fact, you can just use selectrow_array for the whole
thing, which would probably be better.
Also, we can have it be keyword_to_id ($) (since it's a real subroutine, and
respects prototypes).
And you might as well export it.
Attachment #178055 -
Flags: review?(mkanat) → review-
|
|
Assignee | |
Comment 3•20 years ago
|
||
And also, why the Bugzilla::Config dependency? I think we don't need that. But
we probably do need a Bugzilla dependency.
Severity: normal → enhancement
|
|
Reporter | |
Updated•19 years ago
|
Assignee: vladd → nobody
Status: ASSIGNED → NEW
|
||
Comment 4•19 years ago
|
||
Keyword.pm is based on Product.pm. Putting this file here for now.
Assignee: nobody → LpSolit
Attachment #178055 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #201696 -
Flags: review?
|
|
||
Updated•19 years ago
|
Attachment #201696 -
Flags: review?
|
|
||
Updated•18 years ago
|
Assignee: LpSolit → administration
Status: ASSIGNED → NEW
|
|
||
Comment 5•17 years ago
|
||
Bugzilla::Keyword has been implemented in bug 328638 and also included the ability to get keywords by name.
|
|
||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•