Closed
Bug 286949
Opened 20 years ago
Closed 19 years ago
JS Exception in pageInfo.js on pages with XLink links
Categories
(SeaMonkey :: Page Info, defect)
SeaMonkey
Page Info
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla.mozilla.org-3, Assigned: bugzilla.mozilla.org-3)
References
()
Details
(Keywords: fixed1.8.1, Whiteboard: fixed-seamonkey1.0.3)
Attachments
(2 files, 2 obsolete files)
|
(deleted),
patch
|
db48x
:
review+
neil
:
superreview+
asa
:
approval1.8b3+
darin.moz
:
approval1.8.1+
csthomas
:
approval-seamonkey1.0.3+
csthomas
:
approval-seamonkey1.1a+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
When the Page Info window is opened for a page that contains XLink links, the
following error message is printed to the JavaScript Console:
Error: uncaught exception: [Exception... "'[JavaScript Error: "ioService is not
defined" {file: "chrome://browser/content/pageInfo.js" line: 532}]' when calling
method: [nsIDOMNodeFilter::acceptNode]" nsresult: "0x80570021
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame ::
chrome://browser/content/pageInfo.js :: doGrab :: line 448" data: yes]
|
Assignee | |
Comment 1•20 years ago
|
||
The handling of XLink now follows the pattern as used in my patch for
metaData.js in bug 175074.
Attachment #178049 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 2•20 years ago
|
||
Attachment #178050 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #178050 -
Flags: review?(db48x)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 178050 [details] [diff] [review]
Patch for xpfe
A baseURI isn't a URI, and I reviewed that :-[
Attachment #178050 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
|
||
Comment 4•20 years ago
|
||
Comment on attachment 178050 [details] [diff] [review]
Patch for xpfe
need someone to check that in?
Attachment #178050 -
Flags: review?(db48x) → review+
|
|
Assignee | |
Comment 5•20 years ago
|
||
> need someone to check that in?
Yes please :-)
|
|
||
Updated•20 years ago
|
Flags: review?(mconnor)
Product: Firefox → Mozilla Application Suite
|
||
Comment 6•20 years ago
|
||
To daniel so he'll remember to check this in once the tree reopens... ;)
Assignee: bugs → db48x
Flags: review+
|
|
Assignee | |
Comment 7•20 years ago
|
||
Daniel, why did you remove my review request for the Firefox patch?
|
|
||
Comment 8•20 years ago
|
||
erm, that's odd. Looks like bz accidentally removed my r+ as well
|
|
||
Updated•20 years ago
|
Attachment #178049 -
Flags: review?(mconnor)
|
|
||
Updated•20 years ago
|
Attachment #178050 -
Flags: review+
|
||
Updated•20 years ago
|
Attachment #178049 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #178049 -
Flags: approval-aviary1.1a2?
|
|
Assignee | |
Updated•20 years ago
|
Attachment #178050 -
Flags: approval1.8b3?
|
||
Updated•20 years ago
|
Attachment #178049 -
Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
|
|
||
Updated•20 years ago
|
Attachment #178050 -
Flags: approval1.8b3? → approval1.8b3+
|
|
Assignee | |
Updated•20 years ago
|
Whiteboard: [checkin needed]
|
|
Assignee | |
Comment 9•19 years ago
|
||
Attachment #178049 -
Attachment is obsolete: true
|
||
Updated•19 years ago
|
Assignee: db48x → bugzilla.mozilla.org
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk
|
|
||
Comment 10•19 years ago
|
||
Thanks for the patch Christian!
mozilla/browser/base/content/pageInfo.js; new revision: 1.28;
Attachment #195309 -
Attachment is obsolete: true
|
|
||
Comment 11•19 years ago
|
||
(I changed the patch because it redeclared "url", the xpfe patch needs the same change)
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed] → [checkin needed] (xpfe part)
|
|
||
Comment 12•19 years ago
|
||
mozilla/browser/base/content/pageInfo.js; new revision: 1.25.2.5;
|
|
||
Updated•19 years ago
|
Attachment #208241 -
Attachment description: what I checked in → what I checked in (1.8 branch and trunk)
|
|
||
Updated•19 years ago
|
Attachment #178050 -
Flags: approval1.8.1?
|
|
||
Comment 13•19 years ago
|
||
Checked in the XPFE patch (after merging to tip and removing the "var" from before "url".
I'm sorry the checkins just fell through like that. :(
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•19 years ago
|
Whiteboard: [checkin needed] (xpfe part)
|
||
Updated•19 years ago
|
Attachment #178050 -
Flags: approval1.8.1? → approval1.8.1+
|
|
||
Updated•19 years ago
|
Attachment #178050 -
Flags: approval-seamonkey1.0.2?
|
||
Comment 15•19 years ago
|
||
Comment on attachment 178050 [details] [diff] [review]
Patch for xpfe
first a= for SM1.0.3, one more to go
|
||
Comment 16•19 years ago
|
||
Comment on attachment 178050 [details] [diff] [review]
Patch for xpfe
Requesting approval‑seamonkey1.0.3,
instead of approval‑seamonkey1.0.2 which Boris set.
Attachment #178050 -
Flags: approval-seamonkey1.0.2? → approval-seamonkey1.0.3?
Comment on attachment 178050 [details] [diff] [review]
Patch for xpfe
Did this land on 1.8? It didn't have the appropriate approval flags...
a=me for 1.1a
a=me for 1.0.3
Attachment #178050 -
Flags: approval-seamonkey1.1a+
Attachment #178050 -
Flags: approval-seamonkey1.0.3?
Attachment #178050 -
Flags: approval-seamonkey1.0.3+
|
|
||
Comment 19•19 years ago
|
||
(In reply to comment #17)
> (From update of attachment 178050 [details] [diff] [review] [edit])
> Did this land on 1.8? It didn't have the appropriate approval flags...
Yes, as it was written in
[
------- Comment #14 From Boris Zbarsky (gone June 26 -- Jul 13) 2006-06-28 10:10 PDT [reply] -------
Checked in XPFE patch on the 1.8 branch.
]
It had |darin: approval1.8.1+|...
You need to log in
before you can comment on or make changes to this bug.
Description
•