Closed Bug 287127 Opened 20 years ago Closed 20 years ago

crash at www.bungie.net [@ nsHTMLScrollFrame::GetContentInsertionFrame]

Categories

(Firefox :: General, defect)

x86
Windows 2000
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: stevee, Assigned: roc)

References

()

Details

(Keywords: crash, regression, topcrash+)

Crash Data

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050321 Firefox/1.0+ www.bungie.net loads fine for me with the official 20050321 build, but with a later beast build it hangs whilst loading, then firefox can crash out. I suspect bug 282754 may have caused this regression. The website may not be the best coded one in the world, but firefox shouldn't hang/crash because of it.
Yes, I agree about the regression. It would be easy to wallpaper but we need a reduced test case to figure out the correct fix. What's happening is that we're calling nsHTMLScrollFrame::GetContentInsertionFrame and it crashes because the scrollbox's scrolled frame is null. That's really weird. And this is inside a call to GetAbsoluteContainingBlock from the block-in-inline part of ConstructInline.
Attached patch fix (deleted) — Splinter Review
The real problem is that GetContentInsertionFrame gets called before we're done hooking up the frame tree. We don't really need to call GetContentInsertionFrame here.
Assignee: firefox → roc
Status: NEW → ASSIGNED
Attachment #178169 - Flags: superreview?(bzbarsky)
Attachment #178169 - Flags: review?(bzbarsky)
Severity: normal → critical
Comment on attachment 178169 [details] [diff] [review] fix r+sr=bzbarsky
Attachment #178169 - Flags: superreview?(bzbarsky)
Attachment #178169 - Flags: superreview+
Attachment #178169 - Flags: review?(bzbarsky)
Attachment #178169 - Flags: review+
*** Bug 287309 has been marked as a duplicate of this bug. ***
Adding topcrash info for tracking. This is a regression and topcrasher on the Trunk that started on 3/22. I'll keep an eye on Talkback data after teh patch goes in to verify that this crash goes away. Here is a link to all current crashes: http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=nsHTMLScrollFrame%3A%3AGetContentInsertionFrame&vendor=All&product=All&platform=All&buildid=&sdate=&stime=&edate=&etime=&sortby=bbid
Summary: crash at www.bungie.net → crash at www.bungie.net [@ nsHTMLScrollFrame::GetContentInsertionFrame]
This was checked in yesterday, 2005-03-22 19:39 PST. Sorry I forgot to mark FIXED.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 287443 has been marked as a duplicate of this bug. ***
Crash Signature: [@ nsHTMLScrollFrame::GetContentInsertionFrame]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: