Closed
Bug 287389
Opened 20 years ago
Closed 20 years ago
SVG should not munge ua.css at build time
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: tor)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Right now, if SVG is enabled we end up munging ua.css as we build. This causes
the issues mentioned in bug 266930, at least.
Worse, it means that svg.css is loaded at all times, which means it participates
in style resolution for all pages. I'm not so convinced we want the performance
hit on HTML pages just from turning on SVG at build time.
What SVG _should_ be doing is the same thing as what MathML does -- dynamically
adding the SVG sheet to the "catalog sheets" as needed....
Attachment #178492 -
Flags: review?(bzbarsky)
|
Reporter | |
Comment 2•20 years ago
|
||
Comment on attachment 178492 [details] [diff] [review]
switch to catalog style sheet
>Index: content/base/src/nsDocument.cpp
>+nsDocument::EnsureCatalogStyleSheet(const char *aStyleSheetURI)
>+ if (cssLoader && NS_SUCCEEDED(cssLoader->GetEnabled(&enabled)) && enabled) {
...
>+ }
I think you want to close out this if _much_ later. As things stand, if
cssLoader is null or disabled, you'll load the sheet...
Attachment #178492 -
Flags: review?(bzbarsky) → review-
Assignee: general → tor
Attachment #178492 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #178541 -
Flags: review?(bzbarsky)
|
|
Reporter | |
Comment 4•20 years ago
|
||
Comment on attachment 178541 [details] [diff] [review]
fix nesting
r+sr=bzbarsky
Attachment #178541 -
Flags: superreview+
Attachment #178541 -
Flags: review?(bzbarsky)
Attachment #178541 -
Flags: review+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Comment 6•20 years ago
|
||
Shouldn't you cvs remove layout/svg/base/src/install-svg-css.pl as well?
(sr=dbaron on that if you want it)
|
||
Comment 8•20 years ago
|
||
shouldn't nsIDocument get a new IID?
|
|
Reporter | |
Comment 9•20 years ago
|
||
Erm..... yes, it should. tor, could you please rev the iid?
|
Assignee | |
Comment 10•20 years ago
|
||
Updated iid.
You need to log in
before you can comment on or make changes to this bug.
Description
•