Closed
Bug 287945
Opened 20 years ago
Closed 19 years ago
Rebrand bootstrap's BeOS bits
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: sergei_d)
References
Details
(Keywords: fixed1.8.0.1, fixed1.8.1)
Attachments
(7 files, 4 obsolete files)
(deleted),
application/zip
|
Details | |
(deleted),
application/zip
|
kairo
:
approval-seamonkey1.0+
kairo
:
approval-seamonkey1.1a+
|
Details |
(deleted),
application/zip
|
sergei_d
:
review+
|
Details |
(deleted),
application/zip
|
Details | |
(deleted),
application/zip
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
application/zip
|
Details |
See list below (maybe other bits too):
/xpfe/bootstrap/nsNativeAppSupportBeOS.cpp, line 115 -- "mozilla splash",
/xpfe/bootstrap/nsNativeAppSupportBeOS.cpp, line 189 -- const void *data =
rsrc->LoadResource('BBMP', "MOZILLA:SPLASH", &length);
Assignee | ||
Comment 1•19 years ago
|
||
At least having same signature for Firefox and SeaMonakey is funny.
When trying to run both simultaneosly, i have now single *-bin loaded for both.
I don't understand what any of you mean.
/xpfe/bootstrap/nsNativeAppSupportBeOS.cpp is used by Mozilla
/toolkit/xre/nsNativeAppSupportBeOS.cpp is for Firefox (and ThunderBird)
Assignee | ||
Comment 3•19 years ago
|
||
tqh, why we use so complex procedure here?
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsNativeAppSupportBeOS.cpp#98
to set SeaMonkey sugnature instead just using
"application/x-vnd.Mozilla-SeaMonkey"
in http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsNativeAppSupportBeOS.cpp#80
I understand that signature may differ for toolkit-based apps, such Firefox, Sunbird, Thunderbird and whatelse, but for SeaMonkey suite there is only one.
(In reply to comment #3)
> tqh, why we use so complex procedure here?
> ...
> I understand that signature may differ for toolkit-based apps, such Firefox,
> Sunbird, Thunderbird and whatelse, but for SeaMonkey suite there is only one.
>
It was done in the initial port (I think) so that it could be used for different projects without the need to change the code (before toolkit I guess). The way is cause for some trouble and pains, but I havn't touched this. I personally would prefer a #ifdef or such, but it needs some thought. If we did it perfect it would set app-sig on compile (even for new products) and set it both in code and on app (rsrc). If you want to try and resolve this go ahead, as I think this is a bit to much of make-file fiddling and such for me.
Assignee | ||
Comment 5•19 years ago
|
||
New resource file for SeaMonkey. changed both size icons, app version info/number - as it was 0.99 (though, we need some automated way in future) and splash screen.
For misterious reason spash-screen don'w show on my computer with any Suite/SeaMonkey version anymore, so need someone to test new resource.
Attachment #206795 -
Flags: review?(cbiesinger)
Assignee | ||
Comment 6•19 years ago
|
||
found reason why spash didn't show on my computer.
const void *data = rsrc->LoadResource('BBMP', "MOZILLA:SPLASH", &length); in nsNativeAppSupportBeOS.cpp expects that resource is archived bitmap format - BBMP. But my own last attempt (and probably previous splash-screen change by biesi) used simple Windows BMP.
For some reason it worked on Dano-based machines.
So resource file needs update
Assignee | ||
Updated•19 years ago
|
Attachment #206795 -
Attachment is obsolete: true
Attachment #206795 -
Flags: review?(cbiesinger)
Assignee | ||
Comment 7•19 years ago
|
||
Comment on attachment 206795 [details]
mozilla/xpfe/bootstrap/apprunner-beos.rsrc.zip
People, i need help. Something is wrong in my head or in world around.
I checked resource again - and splash-bitmap there is BBMP type! But after running make seamonkey-bin gets (W)BMP type included. And it don't shows here.
But it i change spash-screen resource ins seamonkey-bin by hands to BBMP - all works. So i think resource file is OK
Attachment #206795 -
Attachment is obsolete: false
Assignee | ||
Comment 8•19 years ago
|
||
This time splash-screen is archived bitmap in resource, for sure.
Sorry for previous posting, 'BBMP' is unrelated to archived format.
Works here.
Attachment #206795 -
Attachment is obsolete: true
Attachment #206798 -
Flags: review?(cbiesinger)
Comment 9•19 years ago
|
||
why did you change the app flags from single to multiple?
Assignee | ||
Comment 10•19 years ago
|
||
I use MultipleLaunch flag in development process - to be able to run two seamonkey instances - one mostly opened at lxr.mozila.org, and second one - my development version.
So I will put SingleLaunch back, especially if you think that MultipleLaunch is dangerous for profile-handling.
Assignee | ||
Comment 11•19 years ago
|
||
Attachment #206798 -
Attachment is obsolete: true
Attachment #206798 -
Flags: review?(cbiesinger)
Comment 12•19 years ago
|
||
the bitmap in your file looks somewhat bad, like it was badly dithered... this one looks more like the original splash.
(it's the second attachment + my changed splash + flag changed to single launch; when doing this I only had that version readily available)
Updated•19 years ago
|
Attachment #206880 -
Attachment is patch: false
Attachment #206880 -
Attachment mime type: text/plain → application/octet-stream
Assignee | ||
Comment 13•19 years ago
|
||
nothing visible in splash for R5 in resource file.
Comment 14•19 years ago
|
||
Comment on attachment 206877 [details]
with SingleLaunch flag
ok, so let's go for this one. however, please change the version from 1.5.-33 to 1.5.0 or something :)
Attachment #206877 -
Flags: review+
Assignee | ||
Comment 15•19 years ago
|
||
Attachment #206877 -
Attachment is obsolete: true
Attachment #206880 -
Attachment is obsolete: true
Assignee | ||
Comment 16•19 years ago
|
||
Updated•19 years ago
|
Assignee: jag → sergei_d
Comment 17•19 years ago
|
||
checked in on trunk:
Checking in apprunner-beos.rsrc;
/cvsroot/mozilla/xpfe/bootstrap/apprunner-beos.rsrc,v <-- apprunner-beos.rsrc
new revision: 1.5; previous revision: 1.4
done
Comment 18•19 years ago
|
||
Comment on attachment 206883 [details]
resource for 1.0 Final
a=me for sm 1.0 and 1.1, needs second approval
Attachment #206883 -
Flags: approval-seamonkey1.1?
Attachment #206883 -
Flags: approval-seamonkey1.0?
Comment 19•19 years ago
|
||
Comment on attachment 206883 [details]
resource for 1.0 Final
a=me for 1.0/.1
Attachment #206883 -
Flags: approval-seamonkey1.1?
Attachment #206883 -
Flags: approval-seamonkey1.1+
Attachment #206883 -
Flags: approval-seamonkey1.0?
Attachment #206883 -
Flags: approval-seamonkey1.0+
Comment 20•19 years ago
|
||
fixed on MOZILLA_1_8_0_BRANCH
Checking in apprunner-beos.rsrc;
/cvsroot/mozilla/xpfe/bootstrap/apprunner-beos.rsrc,v <-- apprunner-beos.rsrc
new revision: 1.4.10.1; previous revision: 1.4
done
MOZILLA_1_8_BRANCH
Checking in apprunner-beos.rsrc;
/cvsroot/mozilla/xpfe/bootstrap/apprunner-beos.rsrc,v <-- apprunner-beos.rsrc
new revision: 1.4.2.1; previous revision: 1.4
done
Comment 21•19 years ago
|
||
Hmm, no need to change the strings in /xpfe/bootstrap/nsNativeAppSupportBeOS.cpp? The description is somewhat cryptic for me.
Comment 22•19 years ago
|
||
hm... I think they don't necessarily have to be changed... although maybe they should. I'll let someone else reopen this or file a new bug for it.
Updated•19 years ago
|
Comment 23•19 years ago
|
||
replaced black edges with transparency.
Assignee | ||
Comment 24•19 years ago
|
||
Comment on attachment 218201 [details]
resource, updated icon
nice take, mmadia!
Attachment #218201 -
Flags: review+
Comment 25•19 years ago
|
||
checked in attachment 218201 [details]
Checking in apprunner-beos.rsrc;
/cvsroot/mozilla/xpfe/bootstrap/apprunner-beos.rsrc,v <-- apprunner-beos.rsrc
new revision: 1.6; previous revision: 1.5
done
Comment 26•19 years ago
|
||
unsure what the file should be named.
didn't want to file individual bugs for this and next attachment ( thunderbird's resource file).
Comment 27•19 years ago
|
||
see previous comment.
Assignee | ||
Comment 28•19 years ago
|
||
Due to SeaMonkey transition to toolkit this bug is actual again
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 29•19 years ago
|
||
Sergei:
I don't think it's *this* bug again, I think it only affects a still non-default, new configuration (i.e. suiterunner), and for that you should file a new bug instead of resurrecting a bug that has been filed for different reasons.
Assignee | ||
Updated•19 years ago
|
Blocks: suiterunner
Assignee | ||
Comment 30•19 years ago
|
||
settin Makefile to use apprunner-beos.rsrc and apply it with xres (via rules.mk) to seamonkey-bin
(All works, patch discussed with Standard8 already)
Attachment #223937 -
Flags: review?(cbiesinger)
Comment 31•19 years ago
|
||
Assignee | ||
Comment 32•19 years ago
|
||
Comment on attachment 223937 [details] [diff] [review]
patch
cancelling.
patch will be moved to another bug, according to KaiRo's comment
Attachment #223937 -
Flags: review?(cbiesinger)
Assignee | ||
Comment 33•19 years ago
|
||
Ok, closing finally.
Will use unchecked patches from here in other bugs
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
No longer blocks: suiterunner
You need to log in
before you can comment on or make changes to this bug.
Description
•