Closed
Bug 288038
Opened 20 years ago
Closed 18 years ago
Diff view of (cvs diff) Attachments: some lines can be missing, and/or URL wrong
Categories
(Bugzilla :: Attachments & Requests, defect)
Tracking
()
VERIFIED
DUPLICATE
of bug 233695
People
(Reporter: sgautherie, Assigned: john)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
I saw it twice today, on b.m.o..
Second time is:
https://bugzilla.mozilla.org/attachment.cgi?id=178811
{{
++ content/global/bindings/tree.xml (widgets/tree.xml)
}}
is missing from
https://bugzilla.mozilla.org/attachment.cgi?id=178811&action=diff
Then requesting 'Raw Unified' has the same bug.
Reporter | ||
Comment 1•20 years ago
|
||
First time was:
https://bugzilla.mozilla.org/attachment.cgi?id=156373&action=diff
which misses
{{
--- mozilla/mailnews/base/search/resources/locale/en-US/filter.properties 28 Feb
2003 00:21:23 -0000 1.16
+++ mozilla/mailnews/base/search/resources/locale/en-US/filter.properties 17 Aug
2004 21:13:29 -0000
}}
from
https://bugzilla.mozilla.org/attachment.cgi?id=156373
Then requesting 'Raw Unified' has the same bug.
Comment 2•19 years ago
|
||
Reporter | ||
Comment 3•19 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7.8) Gecko/20050511] (release) (W98SE)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050701] (nightly) (W98SE)
Another issue: 'moz' is (now !?) added at the beginning of the filenames...
{{ <https://bugzilla.mozilla.org/attachment.cgi?id=178811&action=diff>
(+) mozmozilla/toolkit/content/jar.mn (-1 lines)
(+) mozmozilla/toolkit/content/widgets/tree.xml (-8 / +3 lines)
}}
Or could this one be a "new wanted feature" !??
Reporter | ||
Updated•19 years ago
|
Flags: blocking2.20?
Reporter | ||
Comment 4•19 years ago
|
||
(In reply to comment #3)
> (+) mozmozilla/toolkit/content/jar.mn (-1 lines)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b3) Gecko/20050710 SeaMonkey/1.0a]
(nightly) (W98SE)
Or on the filename:
{{ <https://bugzilla.mozilla.org/attachment.cgi?id=175059&action=diff>
(+) mozilla/xpinstall/wizard/windows/setup/diadialogs.c (-16 / +32 lines)
}}
Reporter | ||
Comment 5•19 years ago
|
||
(In reply to comment #4)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b3) Gecko/20050710 SeaMonkey/1.0a]
(nightly) (W98SE)
Or in-between:
{{ <https://bugzilla.mozilla.org/attachment.cgi?id=152585&action=diff>
(+) mozilla/xpinstall/packager/winwin_mfcembed/config.it (-1 / +1 lines)
+) mozilla/xpinstall/packager/winwindows/config.it (-1 / +1 lines)
}}
Sigh :-(
Comment 6•19 years ago
|
||
This is irritating, certainly ('ve seen it happen), but not a release blocker.
Flags: blocking2.20? → blocking2.20-
Reporter | ||
Comment 7•19 years ago
|
||
(In reply to comment #6)
> This is irritating, certainly ('ve seen it happen), but not a release blocker.
Additional bad behaviour example related to the link part:
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b3) Gecko/20050714 SeaMonkey/1.0a]
(nightly) (W98SE)
https://bugzilla.mozilla.org/attachment.cgi?id=152140&action=diff
displays as
(-) mozmozilla/mailnews/addrbook/resources/content/addressbook.js (-4 / +8 lines)
and links to
http://lxr.mozilla.org/mozilla/source/la/mailnews/addrbook/resources/content/addressbook.js
which obviously lead to a
"This file does not exist."
I guess this bug is a regression, but I can't verify it since I use b.m.o. site
only.
Even if it's not a "core" (database, ...) feature, it's seems useful enough to
be a blocker; but that's only my thought...
Summary: Diff view of (cvs diff) Attachments: some lines can be missing → Diff view of (cvs diff) Attachments: some lines can be missing, and/or URL wrong
Comment 8•19 years ago
|
||
Looks like this may actually be a flaw in PatchReader/Raw.pm. Gerv provided
this patch, and it fixes the problem for several diffs on a test instance of
b.m.o.
Here are the diffs on the original instance:
https://bugzilla.mozilla.org/attachment.cgi?id=187534&action=diff&headers=1&context=file
https://bugzilla.mozilla.org/attachment.cgi?id=187534&action=diff&headers=1&context=file
https://bugzilla.mozilla.org/attachment.cgi?action=diff&id=187534&collapsed=&headers=1&context=30
And here they are on the test instance:
https://bugzilla.mozilla.org/test/attachment.cgi?id=187534&action=diff&headers=1&context=file
https://bugzilla.mozilla.org/test/attachment.cgi?id=187534&action=diff&headers=1&context=file
https://bugzilla.mozilla.org/test/attachment.cgi?action=diff&id=187534&collapsed=&headers=1&context=30
Reporter | ||
Comment 9•19 years ago
|
||
(In reply to comment #8)
> Created an attachment (id=190249) [edit]
> patch for PatchReader/Raw.pm that fixes problem
>
https://bugzilla.mozilla.org/attachment.cgi?id=187534&action=diff&headers=1&context=file
https://bugzilla.mozilla.org/attachment.cgi?id=187534&action=diff&headers=1&context=file
https://bugzilla.mozilla.org/attachment.cgi?action=diff&id=187534&collapsed=&headers=1&context=30
>
https://bugzilla.mozilla.org/test/attachment.cgi?id=187534&action=diff&headers=1&context=file
https://bugzilla.mozilla.org/test/attachment.cgi?id=187534&action=diff&headers=1&context=file
https://bugzilla.mozilla.org/test/attachment.cgi?action=diff&id=187534&collapsed=&headers=1&context=30
(You might want to check in both list why your 2 first URLs are identical...)
Anyway,
I tested comment 0 example:
Using the '/test/' URL fixes the issue on the filename links :-)
(Should review be asked for this patch !?)
Then, we need another patch for the content issue.
Attachment #190249 -
Flags: review?
Updated•19 years ago
|
Assignee: attach-and-request → gerv
Comment 10•19 years ago
|
||
John Keiser maintains Patch Reader; this bug needs to be assigned to him, really.
Gerv
Assignee: gerv → john
Comment 11•19 years ago
|
||
Comment on attachment 190249 [details] [diff] [review]
patch for PatchReader/Raw.pm that fixes problem
This patch affects PatchReader/Raw.pm which is not part of the Bugzilla code. This has nothing to do with us and requesting review doesn't make sense. See gerv's previous comment.
Attachment #190249 -
Flags: review?
Comment 12•18 years ago
|
||
Is this a dupe of bug 233695?
Reporter | ||
Comment 13•18 years ago
|
||
Let's see:
Comment 0: Looks much like bug 233695.
Comment 1: Might be bug 233695 too !?
Comment 3: WorksForMe now.
Comment 4: WorksForMe now.
Comment 5: WorksForMe now.
Comment 7: WorksForMe now.
(Comment 8 'test' links are '404 Not Found' now.)
Still very much interested in a solution, whether we patch the tool, or use a version that works ... after (one, no:) two years :-/
Depends on: 233695
Reporter | ||
Comment 15•18 years ago
|
||
(In reply to comment #14)
> *** Bug 365383 has been marked as a duplicate of this bug. ***
Quote from that bug:
{
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2pre) Gecko/20061229
SeaMonkey/1.1] (nightly) (W2Ksp4)
"Bugzilla was upgraded on December 26th at 6pm PST (2am Wednesday
UTC)." regressed comment 7.
}
Changing W98 to W2K, as I am currently dropping my old W98SE.
Depends on: bmo-regressions-0812
OS: Windows 98 → Windows 2000
Reporter | ||
Updated•18 years ago
|
Blocks: bmo-regressions-0812
No longer depends on: bmo-regressions-0812
Updated•18 years ago
|
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 17•18 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a3pre) Gecko/20070306 SeaMonkey/1.5a] (nightly) (W2Ksp4)
For the record,
my comment 13 stands, with current b.m.o BugZilla version, whatever it is.
***
I could have thought there was more data/discussion/work done here than there
...
but, all right, let's V.Duplicate.
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 18•18 years ago
|
||
(In reply to comment #15)
> (In reply to comment #14)
> > *** Bug 365383 has been marked as a duplicate of this bug. ***
>
> "Bugzilla was upgraded on December 26th at 6pm PST (2am Wednesday
> UTC)." regressed comment 7.
To be explicit, I noted there that that (temporary) regression is now WFM:
comment 13 stands as it was written.
You need to log in
before you can comment on or make changes to this bug.
Description
•