Closed
Bug 288640
Opened 20 years ago
Closed 20 years ago
Build internet search service in tier_99, to avoid bad nsIBookmarksService dependencies
Categories
(Toolkit Graveyard :: Build Config, defect, P1)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: benjamin, Assigned: benjamin)
Details
(Whiteboard: [xulrunner bad dependency])
Attachments
(1 file)
|
(deleted),
patch
|
neil
:
first-review+
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
The internet search service is really part of the applications, and should not
be built as part of the toolkit (or in tier 50). It has bad dependencies on
nsIBookmarksService. This bug is for makefile/build changes to move it to the
app build process in tier 99.
|
Assignee | |
Updated•20 years ago
|
Whiteboard: [xulrunner bad dependency]
|
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #179291 -
Flags: first-review?(neil.parkwaycc.co.uk)
|
||
Comment 2•20 years ago
|
||
(In reply to comment #0)
>It has bad dependencies on nsIBookmarksService.
Those dependencies are only used by xpfe's search sidebar. #ifdef them out?
|
|
Assignee | |
Comment 3•20 years ago
|
||
The point is that the xpfe/components/search is not part of "the toolkit", so I
want to move it to the application-specific build tier.
|
|
Assignee | |
Updated•20 years ago
|
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
|
|
||
Comment 4•20 years ago
|
||
Comment on attachment 179291 [details] [diff] [review]
Move xpfe/components/search to tier_99
rs=me (untested)
Attachment #179291 -
Flags: first-review?(neil.parkwaycc.co.uk) → first-review+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Comment on attachment 179291 [details] [diff] [review]
Move xpfe/components/search to tier_99
This is not quite as trivial as some other of my build-config patches waiting
for approval, but I think it's important for the xulrunner PR.
Attachment #179291 -
Flags: approval1.8b2?
|
||
Comment 6•20 years ago
|
||
Comment on attachment 179291 [details] [diff] [review]
Move xpfe/components/search to tier_99
a=asa
Attachment #179291 -
Flags: approval1.8b2? → approval1.8b2+
|
|
Assignee | |
Comment 7•20 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•