The bugzilla-tip install on landfill has a classification_id with this definition, in the products table: classification_id smallint(6) default '1' Whereas the Schema creates classification_id with this definition: classification_id smallint(6) NOT NULL default '1' This only happens when we create the raw database, not when we add classifications to an old install, for some reason.

Yup, adding the new field to an existing database was inconsistent.

Comment on attachment 179970 [details] [diff] [review] suggested patch OK, then we also need to fix it for all the people who currently have it set incorrectly in their DB. Just a simple bz_change_field_type toward the end of the LEGACY CHECKS should do it.

Here's an updated patch. I'm marking it "temporary" as it will always update the field for every checksetup.pl call. The long term fix will occur after the DB functions can correctly tell us when a field is set to "NOT NULL". Max writes: > Unfortunately the DB functions are currently broken in their ability > to tell if a field has changed or not. This will be fixed > eventually (I'm writing entirely new functions), but for right now > there's no way to avoid it. We need to have this change in before > we have the patch in that fixes the problem. So I am OK with living > with a few days of this message every time we run checksetup, on the > tip.

Comment on attachment 180022 [details] [diff] [review] temporary patch r=mkanat by inspection.

I don't like running this every time. :) Let's find something detectable we can tie this to before 2.20 ships. Make sure we get a bug filed on that if there isn't one already.

The repeating message will actually be solved by bug 285111, as will any and all repeating messages of this type, because the installation checks will become accurate. Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.390; previous revision: 1.389 done