Closed
Bug 290429
Opened 20 years ago
Closed 20 years ago
missing |this.| in error case results in code that will never work
Categories
(Core Graveyard :: Error Console, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: ajschult784)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
caillon
:
approval1.8b2+
|
Details | Diff | Splinter Review |
JavaScript error: chrome://global/content/consoleBindings.xml, line 82:
appendMessage is not defined
|
Assignee | |
Comment 1•20 years ago
|
||
Assignee: timeless → ajschult
Status: NEW → ASSIGNED
Attachment #180775 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #180775 -
Flags: review?(neil.parkwaycc.co.uk)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 180775 [details] [diff] [review]
the patch
For a moment there I thought this was my fault but in fact I'd just searched
and replaced existing faulty code, phew!
Attachment #180775 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #180775 -
Flags: superreview+
Attachment #180775 -
Flags: review?(neil.parkwaycc.co.uk)
Attachment #180775 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 180775 [details] [diff] [review]
the patch
really really low risk. fixes error handling.
Attachment #180775 -
Flags: approval1.8b2?
|
||
Comment 4•20 years ago
|
||
Comment on attachment 180775 [details] [diff] [review]
the patch
a=caillon
Attachment #180775 -
Flags: approval1.8b2? → approval1.8b2+
|
|
Assignee | |
Comment 5•20 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•