Closed Bug 290793 Opened 20 years ago Closed 19 years ago

bookmarks menu doesn't scroll with the keyboard

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bugs.caleb, Assigned: roc)

References

Details

(Keywords: regression)

Attachments

(2 files)

fix
(deleted), patch
bzbarsky
: review+
bzbarsky
: superreview+
shaver
: approval1.8b3+
Details | Diff | Splinter Review
livebookmark testcase
(deleted), application/rss+xml
Details
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050417 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050417 Firefox/1.0+ It looks like the Bookmarks menu does not follow the keyboard arrow keys up/down. To reproduce: 1. Open the Bookmarks menu 2. Press the "UP" keyboard arrow The menu should select and scroll to the last item, but instead it only selects, without scrolling to it. Note: you need alot of bookmarks to reproduce. Reproducible: Always Steps to Reproduce:
Keywords: regression
Flags: blocking1.8b2?
Works with 2005-04-03 trunk build, fails with 2005-04-04 trunk build: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-04-03+06%3A00%3A00&maxdate=2005-04-04+08%3A00%3A00&cvsroot=%2Fcvsroot
Assignee: win32 → aaronleventhal
Status: UNCONFIRMED → NEW
Component: Widget: Win32 → Keyboard: Navigation
Ever confirmed: true
QA Contact: ian → bugzilla
Severity: normal → major
Flags: blocking1.8b3+
Flags: blocking1.8b2?
Flags: blocking1.8b2-
Flags: blocking-aviary1.1+
Blocks: deera11y
Given that range, could this be the scrollframe changes?
Attached patch fix (deleted) — — Splinter Review
More code that just sort of randomly pokes around looking for a scrollable view :-(
Assignee: aaronleventhal → roc
Status: NEW → ASSIGNED
Attachment #184041 - Flags: superreview?(bzbarsky)
Attachment #184041 - Flags: review?(bzbarsky)
*** Bug 291430 has been marked as a duplicate of this bug. ***
Attachment #184041 - Flags: superreview?(bzbarsky)
Attachment #184041 - Flags: superreview+
Attachment #184041 - Flags: review?(bzbarsky)
Attachment #184041 - Flags: review+
Comment on attachment 184041 [details] [diff] [review] fix fixes a UI regression
Attachment #184041 - Flags: approval1.8b3?
Comment on attachment 184041 [details] [diff] [review] fix a=shaver
Attachment #184041 - Flags: approval1.8b3? → approval1.8b3+
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attached file livebookmark testcase (deleted) —
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050602 Firefox/1.0+ ID:2005060202 Does not work with live bookmarks ->REOPENING repro: create a new livebookmark with the attached feed (200 items long) try to scroll it in bookmarks menu
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
my bad, restarted and it worked again
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Component: Keyboard: Navigation → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: