Closed
Bug 291265
Opened 19 years ago
Closed 19 years ago
strict javascript warnings in findbar.js
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
VERIFIED
FIXED
mozilla1.8final
People
(Reporter: bugzilla, Assigned: whimboo)
References
Details
Attachments
(2 obsolete files)
I'm seeing a lot of strict javascript warnings in findbar.js. They polute my
JavaScript console making it harder to find other warnings.
Warning: function flashFindBar does not always return a value
Source File: chrome://global/content/findBar.js
Line: 496
Source Code:
}
Warning: function onFindAgainCmd does not always return a value
Source File: chrome://global/content/findBar.js
Line: 530
Source Code:
}
Warning: function onFindPreviousCmd does not always return a value
Source File: chrome://global/content/findBar.js
Line: 549
Source Code:
}
There's also:
Error: document.commandDispatcher.focusedElement.parentNode has no properties
Source File: chrome://global/content/findBar.js
Line: 289
as mentioned in bug 286885 and bug 273910.
|
||
Comment 2•19 years ago
|
||
Assignee: firefox → jason_barnabe
Status: NEW → ASSIGNED
Attachment #181675 -
Flags: review?(gavin.sharp)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 181675 [details] [diff] [review]
patch
Looks fine to me, but I'm not a browser peer and therefore can't review. Feel
free to CC me on any other strict warning bugs, though. Also, in the future,
could you diff from the root of the tree? It makes it easier to apply the
patches.
Attachment #181675 -
Flags: review?(gavin.sharp) → review?(mconnor)
|
Assignee | |
Comment 4•19 years ago
|
||
Jason, I've updated your patch against the actual head and with the notes given
from Gavin. Hope that's ok for you. I will see that bug fixed hopefully soon.
Attachment #181675 -
Attachment is obsolete: true
Attachment #185365 -
Flags: review?(bryner)
|
|
||
Updated•19 years ago
|
Attachment #181675 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #185365 -
Flags: review?(bryner) → review?(benjamin)
|
||
Updated•19 years ago
|
Attachment #185365 -
Flags: review?(benjamin)
Attachment #185365 -
Flags: review+
Attachment #185365 -
Flags: approval-aviary1.1a2+
Comment on attachment 185365 [details] [diff] [review]
Updated patch
mozilla/toolkit/components/typeaheadfind/content/findBar.js 1.11
Attachment #185365 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Updated•19 years ago
|
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Firefox1.5
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•