nsClipboard.cpp needs a cleanup. Guess what, it's already done. Insert oohs and aahs here :)

Comment on attachment 181426 [details] [diff] [review] Refactored and with real logging r?

Hmm, I tried cut'n'paste to Mozilla (a bugzilla bugreport) from bdb (stacktrace) and got 'boxes'. Although not from other BeOS-apps. Pasted the text to Stylededit and copied, still got 'boxes'. Saving and opening the text made it work ok though, so maybe it's bdb and utf-8 conversion problem. It's probably the same with the code in CVS now.

There was a problem with a recompile that caused that, so this patch was not to blaim.

Comment on attachment 181426 [details] [diff] [review] Refactored and with real logging r=sergei_d

looks like this is waiting review and commit? Adding to the BeOS blocking bug so we don't forget it.

It's not completly working, So don't check this in! It's something in the utf8<->utf16 conversion that's wrong.

Comment on attachment 181426 [details] [diff] [review] Refactored and with real logging I need to create a new patch for this..

Does it make any difference - in one place i see UCS2-UTF8 conversion, in second - UTF8-UTF16 conversion?

the NS_Convert* functions treat UCS-2 and UTF-16 identically.

tqh, what is status of this clipboard rewrite? Weren't some pieces already commited in other patches?

This is completly seperate from anything else. I wrote it to learn about transfereble and mime-conversion, and to clean the current messy code up. Unfortunatly the patch has bugs in it, and as the current code works I havn't put any priority to it. So the only thing this code would do is clean the current code up.

Moving forward to Firefox 3

We don't support BeOS any more.

In the graveyard, code referred to doesn't exist to be fixed.