Closed
Bug 291846
Opened 20 years ago
Closed 20 years ago
Save Link/Image As are dysfunctional: File not saved after selecting
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox1.5
People
(Reporter: By-Tor, Assigned: Biesinger)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
asa
:
approval-aviary1.1a1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050425 Firefox/1.0+ (bangbang023)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050425 Firefox/1.0+ (bangbang023)
When trying to save an image using the Save Image As context menu, the dialog
for where to save the file appears, but no file is saved. The same happens with
Save Link As with certain file types such as XPI files.
Reproducible: Always
Steps to Reproduce:
1. Select Save Image As...
2. Confirm the file name to download
3.
Actual Results:
No file is actually downloaded.
Expected Results:
The file should have downloaded as usual.
Comment 1•20 years ago
|
||
Yep it is also happening here (Gecko/20050425 Firefox/1.0+).
It happens for all types of images and xpi files.
I am confirming this, couldn't find a duplicate
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050425
Firefox/1.0+
Confirming
this must be a fairly recent regression
I'm sure it worked a days ago
Updated•20 years ago
|
Keywords: regression
Comment 3•20 years ago
|
||
possible falout from bug 290648
CC cbiesinger
Reporter | ||
Updated•20 years ago
|
Version: unspecified → Trunk
Assignee | ||
Comment 4•20 years ago
|
||
hm, this does indeed fail for me in a current nightly (linux), but I want to
note that my ffox build with the patch for that bug does not show this problem...
OS: Windows XP → All
Assignee | ||
Comment 5•20 years ago
|
||
(In reply to comment #4)
> hm, this does indeed fail for me in a current nightly (linux), but I want to
> note that my ffox build with the patch for that bug does not show this problem...
That's because that build was slightly out of date - a later change to that
patch broke it :(
Assignee: firefox → cbiesinger
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → Firefox1.1
Assignee | ||
Comment 6•20 years ago
|
||
let's pass a string for the string argument and a null for the object argument
very low risk patch
Attachment #181832 -
Flags: review?(mconnor)
Attachment #181832 -
Flags: approval-aviary1.1a?
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Updated•20 years ago
|
Flags: blocking-aviary1.1+
Updated•20 years ago
|
Attachment #181832 -
Flags: review?(mconnor) → review+
Comment 7•20 years ago
|
||
Comment on attachment 181832 [details] [diff] [review]
patch
a=asa
Attachment #181832 -
Flags: approval-aviary1.1a? → approval-aviary1.1a+
Comment 8•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050425
Firefox/1.0+
I can't download these lovely sin city wallpapers :(
http://sincitythemovie.com/misc/wallpapers/wp_jpgs/
Assignee | ||
Comment 9•20 years ago
|
||
Checking in toolkit/content/contentAreaUtils.js;
/cvsroot/mozilla/toolkit/content/contentAreaUtils.js,v <--
contentAreaUtils.jsnew revision: 1.69; previous revision: 1.68
done
btw, as for comment 8: comments like that are in general not useful once there
is a patch, and often not even before that...
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•