User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050422 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050422 Firefox/1.0+ The left panel from Themes Manager is scrollable but not resizeable. This could be quite simple to correct with a modification at toolkit.jar -> content/mozapps/extensions/extensions.xul including a splitter between "extensionsView" and "themePreviewArea" Code: ... </action> </rule> </template> </view> <splitter class="extension-splitter" /> <vbox flex="5" id="themePreviewArea" class="themePreviewArea" hidden="true"> <deck id="previewImageDeck" flex="1"> <vbox id="noThemeSelected" pack="center" align="center"> <label class="previewText">&previewNoThemeSelected.label;</label> </vbox> <vbox id="noPreviewImage" pack="center" align="center"> <label class="previewText">&previewNoPreviewImage.label;</label> </vbox> <vbox id="previewImageContainer" align="center" pack="center" style="overflow: auto;"> <description> <image id="previewImage"/> </description> </vbox> </deck> </vbox> </hbox> <hbox ... The class "extension-splitter" could be used to hidde this splitter at Extensions Manager... Reproducible: Always Steps to Reproduce: 1.Open Themes Manager 2.Try to resize left panel to see for example long descriptions 3. Actual Results: Left panel isn't resizable Expected Results: Should be resizable

confirming as a valid RFE.

Here is how I'd do it for WinStripe. It involves several other files to accomplish this properly due to margins in richView, etc. as can be seen by the diff. I'd suggest also adding persists to the left panel's width. At least it is a starting point for someone.

Hi Robert, This Patch works fine for me. I agree it would be nice the capability to remember last configured size (if I correctly understood your persists considerations). I'm sorry I don't have the knowledges to develop it...

*** Bug 294377 has been marked as a duplicate of this bug. ***

Benjamin - the patch from bug 285584 broke the theme manager ui and this patch fixes the regression and adds a splitter between the themes and the theme preview which is what this bug is about. I've tested this on both Win32 and Mac OS X with Firefox and on Win32 with Thunderbird.

Comment on attachment 186775 [details] [diff] [review] patch It turns out that bug 298140 fixes the regression so I'm going to hold off asking for review on this until after 1.1a2.

Comment on attachment 186775 [details] [diff] [review] patch Rob, please don't "hold off" on any patches for review. The later things get, the less likely I am to want to take changes, especially UI changes like this, which needs review from Ben Goodger.

Corrects a slight problem with the position of the splitter on Win32... otherwise it is the same patch.

This is an extension that does the same thing as the patch except for persisting the width since that would continue to persist after the extension is uninstalled.

Comment on attachment 187566 [details] [diff] [review] patch (previous one bit rotted) mconnor - this is even more necessary now that bug 296566 landed since it displays update messages and the update now button on the individual items listed. With most themes if an update is found about half of the button to install the update is cut off.

We should at least make the Theme Manager wide enough by default so the Update Now button isn't cut off.

The patch and xpi were both written before the change to extension / theme update. If it is decided this change is ok then I'll see how best to make sure the button is shown using the default width with different description text lengths.

Comment on attachment 187566 [details] [diff] [review] patch (previous one bit rotted) bit rotted

With it being so late in the cycle I think it is better to fix this with the EM ui rewrite during the next cycle. http://wiki.mozilla.org/Firefox:Extension_Manager_UI If at some point it is decided that this approach is desired and someone has time to review a patch for this go ahead and reassign it back to me.

This bug is annoying in the new 1.5 version. The new version allows for updating themes within their respective windows. However, since the panel cannot be resized, it defeats the purpose of the new feature. One can go to the download website, but then why have the option to install the update directly?

I'm going to try to get this in bug 329045

Fixed on trunk by the checkin of bug 329045