Closed Bug 294075 Opened 20 years ago Closed 18 years ago

password manager should not crash if it fails to get the profile directory [@ nsPasswordManager::Init]

Categories

(Toolkit :: Password Manager, defect)

Product:
Toolkit
Component:
Password Manager
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bryner, Assigned: mwu)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

null-check mSignonFile
(deleted), patch
benjamin
: review+
asa
: approval-aviary1.1a1+
Details | Diff | Splinter Review
This seems to come up in some embedding cases. Currently, if we fail to get NS_APP_USER_PROFILE_50_DIR, the password manager will crash.
Attached patch null-check mSignonFile (deleted) — — Splinter Review
bsmedberg, does this look ok? Is there some other sort of fallback we should have, or a better way of getting the profile directory?
Attachment #183537 - Flags: review?(benjamin)
Comment on attachment 183537 [details] [diff] [review] null-check mSignonFile No, this is perfect.
Attachment #183537 - Flags: review?(benjamin) → review+
Comment on attachment 183537 [details] [diff] [review] null-check mSignonFile requesting approval, trivial null check
Attachment #183537 - Flags: approval-aviary1.1a1?
Comment on attachment 183537 [details] [diff] [review] null-check mSignonFile a=asa
Attachment #183537 - Flags: approval-aviary1.1a1? → approval-aviary1.1a1+
Brian: was this patch landed? Should this bug be closed?
No, the patch hasn't landed yet.
Version: unspecified → Trunk
*** Bug 306424 has been marked as a duplicate of this bug. ***
Whiteboard: [checkin needed]
Severity: normal → critical
Summary: password manager should not crash if it fails to get the profile directory → password manager should not crash if it fails to get the profile directory [@ nsPasswordManager::Init]
Flags: blocking1.9a1+
Brian: are you going to land this patch?
*** Bug 340842 has been marked as a duplicate of this bug. ***
here's a list of all the lines i find objectionable for that function: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp&rev=1.77&mark=251,254,257,273,278,285,287-288#245 first, one shouldn't claim to have inited until the end. second all the assertions are bogus and should be handled. but of course the patch posted would fix the average crash.
Assignee: bryner → nobody
This was fixed by bug 221634.
Assignee: nobody → michael.wu
Whiteboard: [checkin needed]
Status: NEW → RESOLVED
Closed: 18 years ago
Depends on: 221634
Resolution: --- → FIXED
*** Bug 333115 has been marked as a duplicate of this bug. ***
Product: Firefox → Toolkit
Crash Signature: [@ nsPasswordManager::Init]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: