Closed Bug 294823 Opened 20 years ago Closed 19 years ago

ASSERTION: max element width exceeded desired width: 'PR_FALSE'

Categories

(Core :: Layout: Tables, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.8beta3

People

(Reporter: martijn.martijn, Assigned: bernd_mozilla)

Details

(Keywords: testcase)

Attachments

(1 file, 1 obsolete file)

See upcoming testcase. ###!!! ASSERTION: max element width exceeded desired width: 'PR_FALSE', file ../../../mozilla/layout/tables/nsTableRowFrame.cpp, line 971 This seems to be a result of the checkin of the first patch in bug 292690. With the patch I get this assertion in my debug, without it not (tested with the bugzilla which assert appr. 5 times with the patch).
Attached file Testcase (deleted) —
This should assert, it does for me.
Flags: blocking1.8b3?
I think we should just remove this assertion. Right?
I think we should fix layout to avoid to report crappy MEW values ;-), at least with the patch that I attached to bug 292690 it does not assert.
it probably should be rather a warning that makes clear that things are already going south
Attached patch patch [Checked in: Comment 7] (obsolete) (deleted) — Splinter Review
Robert is right. We should just remove the assert, it is bogus. The block below the cell reports a large MEW but did get during the incr. reflow only a small available width as the column is very thin (the first cell is empty which causes 0 witdh on the first colum). The table rebalances later based on the MEW requirements so there is no crappy MEW. The assertion is from a time (2001) when people (chris and I) assumed that a block should never shrink below MEW. But now that we have the table frames handling overflow the block des. size can shrink below MEW.
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
Attachment #185979 - Flags: superreview?(roc)
Attachment #185979 - Flags: review?(roc)
Attachment #185979 - Flags: superreview?(roc)
Attachment #185979 - Flags: superreview+
Attachment #185979 - Flags: review?(roc)
Attachment #185979 - Flags: review+
Comment on attachment 185979 [details] [diff] [review] patch [Checked in: Comment 7] just removes the assertion, debug-build only, so no risk
Attachment #185979 - Flags: approval1.8b3?
Attachment #185979 - Flags: approval1.8b3? → approval1.8b3+
Whiteboard: [checkin needed]
Comment on attachment 185979 [details] [diff] [review] patch [Checked in: Comment 7] mozilla/layout/tables/nsTableRowFrame.cpp 3.368
Attachment #185979 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.8beta3
Attachment #185979 - Attachment description: patch → patch [Checked in: Comment 7]
Flags: blocking1.8b3?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: