Closed Bug 295235 Opened 20 years ago Closed 19 years ago

Remove remaining contents.rdf from Firefox (stop using installed-chrome.txt)

Categories

(Toolkit Graveyard :: Build Config, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta3

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(2 files)

This is a bug for getting rid of the remaining contents.rdf files from Firefox, so that we don't need to use installed-chrome.txt. This is pretty much some theme registrations and a few extensions.
Attached patch winstripe, rev. 1 [checked in] (deleted) — Splinter Review
This is windows-only (except for the package-fixup patch, which is random cleanup of leftover files from days of old).
Attachment #184322 - Flags: first-review?(mconnor)
Comment on attachment 184322 [details] [diff] [review] winstripe, rev. 1 [checked in] sweet.
Attachment #184322 - Flags: first-review?(mconnor) → first-review+
Attachment #184322 - Flags: approval-aviary1.1a2?
Comment on attachment 184322 [details] [diff] [review] winstripe, rev. 1 [checked in] a=shaver
Attachment #184322 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Attachment #184322 - Attachment description: winstripe, rev. 1 → winstripe, rev. 1 [checked in]
Attachment #185571 - Flags: first-review?(mconnor)
Attachment #185571 - Flags: first-review?(mconnor) → first-review+
Attachment #185571 - Flags: approval-aviary1.1a2?
Bug 281988 saw the removal of toolkit/components/passwordmgr/resources/content/contents.rdf.in toolkit/mozapps/contents-content.rdf.in at 2005-05-20 05:58. These files are still listed allmakefiles.sh at lines 1023-4, causing sed to throw a (harmless) "file not found" message. Perhaps this could also be cleaned up.
Attachment #185571 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
All fixed for 1.8b3! We should keep an eye open for installed-chrome.txt reappearing in Firefox or Thunderbird builds.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta3
Not sure whether this comment is valid or not, but here goes. I can still see chrome/installed-chrome.txt, in the hourly ZIP builds. It contains: skin,install,url,jar:resource:/chrome/reporter.jar!/skin/classic/reporter/ skin,install,url,jar:resource:/chrome/classic.jar!/skin/classic/browser/ When I start firefox, I get this in the JSConsole: Failed to load old-style contents.rdf at 'jar:resource:///chrome/reporter.jar!/skin/classic/reporter/contents.rdf'. Failed to load old-style contents.rdf at 'jar:resource:///chrome/classic.jar!/skin/classic/browser/contents.rdf'. This was tested with a new build and an old profile.
Caleb, what OS is that?
(In reply to comment #8) > Caleb, what OS is that? Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050607 Firefox/1.0+ ID:2005060720
I guess http://lxr.mozilla.org/seamonkey/source/allmakefiles.sh#1037 (toolkit/components/passwordmgr/resources/content/contents.rdf) can now be removed since the respective contents.rdf.in is gone.
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: