Closed
Bug 295460
Opened 19 years ago
Closed 6 years ago
Should (content instanceof ChromeWindow) not be true?
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: peterv)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
I queried Bugzilla for instanceof ChromeWindow and found no hits, which surprised me, as Mozilla 1.6 has this bug. Steps to reproduce problem: 1. From the browser, open the JS console 2. Evaluate top.opener.content instanceof ChromeWindow Expected result: false Actual result: true Workaround: use Components.interfaces.nsIDOMChromeWindow
![]() |
||
Updated•19 years ago
|
Keywords: helpwanted
Comment 1•19 years ago
|
||
It returns true for me now, with the 2005-08-27 trunk build. -> WFM?
Reporter | ||
Comment 2•19 years ago
|
||
(In reply to comment #1) >It returns true for me now, with the 2005-08-27 trunk build. -> WFM? Comment #0 says Expected result: false
![]() |
||
Comment 3•19 years ago
|
||
This happens because sClassInfoData[class_name_struct->mDOMClassInfoID].mProtoChainInterface is nsIDOMWindow for chromewindow. And that happens because the classinfo for ChromeWindow is: DOM_CLASSINFO_MAP_BEGIN_NO_CLASS_IF(ChromeWindow, nsIDOMWindow) which means to use nsIDOMWindow as the proto chain interface. Should we be using nsIDOMChromeWindow instead? I'm not sure what else that proto chain interface affects...
Flags: blocking1.9a1?
Updated•18 years ago
|
Flags: blocking1.9a1? → blocking1.9-
Whiteboard: [wanted-1.9]
Updated•18 years ago
|
Status: NEW → ASSIGNED
Updated•18 years ago
|
Assignee: general → jst
Status: ASSIGNED → NEW
Updated•17 years ago
|
Flags: wanted1.9+
Whiteboard: [wanted-1.9]
Updated•15 years ago
|
QA Contact: ian → general
Assignee | ||
Comment 4•15 years ago
|
||
Looks like this is fixed now. |alert(top.opener.content instanceof ChromeWindow)| alerts true for me. No idea what whould have fixed it.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
Comment 5•15 years ago
|
||
(In reply to comment #4) > Looks like this is fixed now. |alert(top.opener.content instanceof > ChromeWindow)| alerts true for me. It's expected to be false.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Updated•15 years ago
|
Assignee: jst → nobody
Assignee | ||
Comment 6•15 years ago
|
||
Sorry, got confused. This works I think, need to think a bit more about it. Also need to add an automated testcase.
Assignee: nobody → peterv
Status: REOPENED → ASSIGNED
Comment 7•14 years ago
|
||
(In reply to comment #6) > Created attachment 418021 [details] [diff] [review] > v1 > > Sorry, got confused. > > This works I think, need to think a bit more about it. Have you thought about it? Any update?
Assignee | ||
Comment 8•6 years ago
|
||
ChromeWindow was removed by switching to WebIDL, there's an isChromeWindow method on Window (added in bug 1383059).
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 6 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•