Closed Bug 296080 Opened 19 years ago Closed 19 years ago

showAutoscrollMarker code is wrong in special situations

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.8.1

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

Details

(Keywords: fixed1.8.1, testcase)

Attachments

(2 files)

See upcoming testcase.
The showAutoscrollMarker relies on documentElement.offsetHeight and -offsetWidth
to get the document height.
This is not the case with the testcase.
The result of this is that the user gets to see the wrong autoscrollmarker image
(autoscroll_all.png).
Attached file testcase (deleted) —
Attached patch patch (deleted) — Splinter Review
This patch fixes it for me. I've also checked this works in xul and xml
environments.
I've also simplified some other code in that function (which I think is an
improvement).
Attachment #184934 - Flags: review?(mconnor)
Assignee: nobody → martijn.martijn
Component: General → XUL Widgets
Flags: review?(mconnor)
OS: Windows XP → All
Product: Firefox → Toolkit
QA Contact: general → xul.widgets
Hardware: PC → All
Version: Trunk → unspecified
Uhm, Gavin, why have you cancelled my review? Did I do something wrong?
Comment on attachment 184934 [details] [diff] [review]
patch

No, the change of component canceled the request. Sorry Martijn.
Attachment #184934 - Flags: first-review?(mconnor)
Ok, no problem, Gavin, but this sounds like a bugzilla bug to me (and I can't
find any bug that is similar to this).
*** Bug 216035 has been marked as a duplicate of this bug. ***
Comment on attachment 184934 [details] [diff] [review]
patch

Anyway, this is good enough. The overflow:hidden case can be solved, but I'll
do that in an eventuel other patch.
Oops! Comment 8 is about the wrong bug (browser tabs can sometimes be very
confusing).
Blocks: 232882
Blocks: 212273
Comment on attachment 184934 [details] [diff] [review]
patch

I'm not in wifi range as I'm writing this, but I swear I've reviewed this patch
before.
Attachment #184934 - Flags: first-review?(mconnor) → first-review+
Whiteboard: [checkin needed]
Checked in by bz.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Attachment #184934 - Flags: branch-1.8.1?(mconnor)
Attachment #184934 - Flags: branch-1.8.1?(mconnor) → branch-1.8.1+
Checked in on the 1.8 branch.
mozilla/toolkit/content/widgets/browser.xml; new revision: 1.70.2.6;
Keywords: fixed1.8.1
Target Milestone: --- → mozilla1.8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: