Closed Bug 296295 Opened 20 years ago Closed 20 years ago

Incorporate bsdiff into the source tree

Categories

(Firefox Build System :: General, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta3

People

(Reporter: darin.moz, Assigned: darin.moz)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Incorporate bsdiff into the source tree This is needed for the new update system. Info on bsdiff can be found here: http://www.daemonology.net/bsdiff/ The patch I'm about to attach is a modified version of bsdiff 4.2. bsmedberg added a CRC32 value to the header and factored out the bzip2 compression.
Attached patch v1 patch (obsolete) (deleted) — Splinter Review
Attachment #185079 - Flags: review?(cls)
This is a tool that will not be distributed with any Mozilla products. We are just going to be using it in our build infrastructure to create binary patches. It lives in the other-licenses section because it uses the BSD Protection License.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta3
Comment on attachment 185079 [details] [diff] [review] v1 patch I'm only looking at the makefile changes. EXTRA_DSO_LDOPTS is only used when linking against shared libs. Also, you'd need to use $(call EXPAND_LIBNAME,...) otherwise the mingw gcc build will complain about the missing Ws2_32.lib file.
Attachment #185079 - Flags: review?(cls) → review-
Attached patch v2 patch (deleted) — Splinter Review
This version of the patch includes the following changes: o Build as a host utility (HOST_PROGRAM) since the generated program need not be included in our releases. o Build as C code since there isn't support for HOST_CPPSRCS. (The code was not really using C++ anyways.) cls: In builds that define CROSS_COMPILE, I plan to simply not build this module. I figure that that is fine since it should really only be something we need from our main release tinderboxen anyways. If we need to cross-compile this module at some point in the future, then we would need to cross-compile libbz2 as well.
Attachment #185079 - Attachment is obsolete: true
Attachment #185516 - Flags: review?(cls)
Attachment #185516 - Flags: review?(cls) → review+
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: