Closed
Bug 296597
Opened 19 years ago
Closed 19 years ago
attempting to save a detached attachment opens it instead
Categories
(MailNews Core :: Attachments, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: neil)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mnyromyr
:
review+
Bienvenu
:
superreview+
asa
:
approval1.8b3+
|
Details | Diff | Splinter Review |
With linux suite trunk 20050603, if I detach an attachment and then attempt to
save it (using save as from the context menu), it "opens" the attachment
instead, either in a browser window, or with the
how-do-you-want-to-handle-this-file dialog. It should just bring up the file
picker and let me save it.
Assignee | ||
Comment 1•19 years ago
|
||
It looks as if we don't really have a way to save detached attachments
[Thunderbird also displays the helper dialog for both open and save]
unless perhaps we should hand off to saveURL? What would that involve?
Comment 2•19 years ago
|
||
saveURL basically only wants the URL (as a string, if I recall correctly). it
will then show a filepicker and save the URL.
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 185362 [details] [diff] [review]
Possible patch
>Index: xpfe/communicator/resources/locale/en-US/contentAreaCommands.properties
>===================================================================
>+SaveAttachmentTtle=Save Attachment
SaveAttachmentTitle even?
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 185362 [details] [diff] [review]
Possible patch
this patch works fine for me (with Ttle => Title)
Assignee | ||
Comment 6•19 years ago
|
||
Attachment #185362 -
Attachment is obsolete: true
Attachment #185384 -
Flags: superreview?(bienvenu)
Attachment #185384 -
Flags: review?(mnyromyr)
Comment 7•19 years ago
|
||
Comment on attachment 185384 [details] [diff] [review]
Proposed patch
I'll take care of this for tbird
Attachment #185384 -
Flags: superreview?(bienvenu) → superreview+
Comment 8•19 years ago
|
||
Comment on attachment 185384 [details] [diff] [review]
Proposed patch
I'm not quite happy with SaveAttachmentTitle being in
contentAreaCommands.properties, while messenger.properties contains the very
same as SaveAttachment, but anyway...
While you're at it, you might want to kill the erroneous space before the
ellipsis in <!ENTITY detachAttachmentCmd.label "Detach ...">
(http://lxr.mozilla.org/mozilla/search?string=detach%20...) also. ;-)
Besides, we should probably have different icons in the attachment box for
deleted and detached attachments...
Attachment #185384 -
Flags: review?(mnyromyr) → review+
Comment 9•19 years ago
|
||
(In reply to comment #8)
> Besides, we should probably have different icons in the attachment box for
> deleted and detached attachments...
Thunderbird already has the former, but missis the latter also: see bug 292385.
Assignee | ||
Updated•19 years ago
|
Attachment #185384 -
Flags: approval1.8b3?
Comment 10•19 years ago
|
||
Okay, deleted does work in Mozilla, too (my build was horked there).
Updated•19 years ago
|
Attachment #185384 -
Flags: approval1.8b3? → approval1.8b3+
Assignee | ||
Comment 11•19 years ago
|
||
Patch checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•