Closed
Bug 296965
Opened 19 years ago
Closed 19 years ago
[FIXr]Make scrollIntoView on nsIDOMNSHTMLElement scriptable
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Right now, scrollIntoView doesn't work on XPCNativeWrappers, because the
function is not scriptable in IDL. We should make it scriptable (with the
required boolean arg) just like document.open is done.
|
Assignee | |
Comment 1•19 years ago
|
||
No need for new iid, since this isn't changing the vtable...
Attachment #191145 -
Flags: superreview?(jst)
Attachment #191145 -
Flags: review?(jst)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 191145 [details] [diff] [review]
Patch
r+sr=jst
(there's a reason for the odd indentation/spacing here, consistency with the
spec indentation. But that's sort of moot in this file, and lost too, since
blur() and focus() don't follow the same scheme... wanna just make
scrollIntoView() indentation match focus and blur here while you're at it?)
Attachment #191145 -
Flags: superreview?(jst)
Attachment #191145 -
Flags: superreview+
Attachment #191145 -
Flags: review?(jst)
Attachment #191145 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #191145 -
Flags: approval1.8b4?
|
|
Assignee | |
Updated•19 years ago
|
Assignee: general → bzbarsky
Priority: -- → P3
Summary: Make scrollIntoView on nsIDOMNSHTMLElement scriptable → [FIXr]Make scrollIntoView on nsIDOMNSHTMLElement scriptable
Target Milestone: --- → mozilla1.8beta4
|
||
Updated•19 years ago
|
Attachment #191145 -
Flags: approval1.8b4? → approval1.8b4+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed on trunk and 1.8 branch.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 4•19 years ago
|
||
This change might have been unnecessary after the patch for 296967.
formElement.scrollIntoView worked for me in Greasemonkey scripts in Aug 11
builds, for example.
|
|
Assignee | |
Comment 5•19 years ago
|
||
It's not necessary in the obvious cases, but it's still needed in general (eg
for the xpt files for the interface to contain this method, etc).
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•