Closed
Bug 297648
Opened 19 years ago
Closed 19 years ago
javascript strict warning in customizeToolbar.xul
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
VERIFIED
FIXED
Firefox 2
People
(Reporter: romain, Assigned: whimboo)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+
It happens when you move an item from a "Customize Toolbar" window, i found two
of them :
The first : open JavaScript Console then do a right click on a Toolbar,
customize... and try to move an item, it makes a JS strict warning (if they have
been enabled).
The second : open JavaScript Console then go to Help Menu, Help Contents, click
on the 5th icon in order to "customize" and try to move an item, it makes a JS
strict warning, located in an other file than above.
Reproducible: Always
Steps to Reproduce:
see details
Actual Results:
A JS strict warning.
Expected Results:
The JS strict warnings are corrected.
Reporter | ||
Comment 1•19 years ago
|
||
Attachment #186196 -
Flags: review?(mconnor)
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•19 years ago
|
||
Please mark all javascript strict warning bugs as blocking bug 296661.
Assignee | ||
Updated•19 years ago
|
Attachment #186196 -
Flags: review?(mconnor) → review?(benjamin)
Reporter | ||
Updated•19 years ago
|
Assignee: nobody → r.bezut
Comment 3•19 years ago
|
||
Comment on attachment 186196 [details] [diff] [review]
patch
Whatever this gDraggingFromPalette variable was supposed to be is now dead.
Please remove it entirely and re-request review from mconnor.
Attachment #186196 -
Flags: review?(benjamin) → review-
Reporter | ||
Updated•19 years ago
|
Attachment #186196 -
Attachment is obsolete: true
Reporter | ||
Comment 4•19 years ago
|
||
Attachment #186461 -
Flags: review?(mconnor)
Comment 5•19 years ago
|
||
Comment on attachment 186461 [details] [diff] [review]
patch v2
please ignore the one in help, since that entire file is going away rsn.
Please fix all other instances of this, including calendar/mail/composer
Attachment #186461 -
Flags: review?(mconnor) → review-
Assignee | ||
Comment 6•19 years ago
|
||
Final patch includes fixes for calendar, composer, mail, and toolkit.
Assignee: r.bezut → hskupin
Attachment #186461 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #196461 -
Flags: review?(mconnor)
Comment 7•19 years ago
|
||
Comment on attachment 196461 [details] [diff] [review]
Final patch
that'll do, not needed for branch, its just a warning
Attachment #196461 -
Flags: review?(mconnor) → review+
Assignee | ||
Updated•19 years ago
|
Whiteboard: [checkin needed]
Comment 8•19 years ago
|
||
Trunk:
mozilla/calendar/sunbird/base/content/customizeToolbar.xul; new revision: 1.3;
mozilla/composer/base/content/customizeToolbar.xul; new revision: 1.2;
mozilla/mail/base/content/customizeToolbar.xul; new revision: 1.10;
mozilla/toolkit/content/customizeToolbar.xul; new revision: 1.14;
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox1.6-
Version: unspecified → Trunk
Assignee | ||
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•