User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050614 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050614 Firefox/1.0+ The first time firefox launched, try to bookmark a page generates a javascript strict warning (if "strict warnings" are enabled). Warning: assignment to undeclared variable description Source File: chrome://browser/content/browser.js Line: 1418 Reproducible: Always Steps to Reproduce: 1. Close all Firefox windows 2. Open Firefox, and go on any page 3. Try to bookmark that page 4. See in the Javascript Console the strict warning ("strict warnings" must be enabled) Actual Results: There is a JS Strict warning. Expected Results: There is not that JS Strict warning anymore.

As I said in the other bugs, please mark all javascript strict warning bugs as blocking bug 296661.

In the last nightly [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050614 Firefox/1.0+], the line is 1392 which is concerned, not 1418 as I have written above. Gavin: You didn't let me enought time to do that :)

Comment on attachment 186344 [details] [diff] [review] patch You can do it when filing, so I assumed you had forgotten. Also, could you patch with -up8 instead of just -u? It makes it easier to review. >Index: browser/base/content/browser.js > try { > title = aDocShell.document.title || url; > charSet = aDocShell.document.characterSet; >- description = BookmarksUtils.getDescriptionFromDocument(aDocShell.document); >+ var description = BookmarksUtils.getDescriptionFromDocument(aDocShell.document); > } The other vars used there were declared just above that block (this is where the -8 comes in handy), so you should probably either declare them all up front, to be consistent. And doesn't http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#1527 cause the same strict warning?

Comment on attachment 186379 [details] [diff] [review] patch v2 needs re-approbal.

Comment on attachment 186379 [details] [diff] [review] patch v2 a=bsmedberg, please land expeditiously

Checking in browser.js; /cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js new revision: 1.449; previous revision: 1.448 done