Closed Bug 298170 Opened 19 years ago Closed 19 years ago

"Report Broken Website" should be followed by ellipsis

Categories

(Other Applications Graveyard :: Reporter, defect)

Product:
Other Applications Graveyard
Component:
Reporter
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: davemilford, Assigned: raccettura)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch directly to xul
(deleted), patch
benjamin
: review+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050619 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050619 Firefox/1.0+ On the Help menu, "Report Broken Website" should be renamed "Report Broken Website..." for HIG consistency (also to be consistent with "Check for Updates". Also, the R keyboard shortcut conflicts with Release Notes. Reproducible: Always
Assignee: nobody → robert
Component: Menus → Reporter
Product: Firefox → Other Applications
QA Contact: menus → xul-client
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch Patch (obsolete) (deleted) — — Splinter Review
Attachment #186920 - Flags: review?(mconnor)
*** Bug 299392 has been marked as a duplicate of this bug. ***
Comment on attachment 186920 [details] [diff] [review] Patch I think that we should do this by adding the ellipsis directly to the XUL, instead of changing the localized entity, to avoid late-l10n problems (AFAIK nobody needs to localize the ellipsis).
Attachment #186920 - Flags: review?(mconnor) → review-
Would the Hebrew localization (a right to left language) not want the elipsis on the left side of the text?
Zach, it should be at the (direction-)logical end, so setting it in the XUL is fine.
Attached patch Patch directly to xul (deleted) — — Splinter Review
Attachment #186920 - Attachment is obsolete: true
Attachment #190409 - Flags: review+
Attachment #190409 - Flags: approval1.8b4+
Status: NEW → ASSIGNED
Fixed
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Will this be made consistent with the rest of the app once the trunk reopens?
(In reply to comment #8) > Will this be made consistent with the rest of the app once the trunk reopens? Bug 317702 filed on removing the hard coded ellipsis.
Depends on: 317702
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: