User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050621 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050621 Firefox/1.0+ Typing a keyword followed by a string into the location bar and pressing enter results in a bookmark keyword URL being generated and loaded. Currently, dragging a URL to the location bar automatically causes it to load. This should be expanded so that dragging a phrase which matches a bookmark keyword query also causes a URL to be generated and loaded. For example, someone could type the phrase "google mozilla" in a forum. If you have a bookmark keyword set up for google (as "google" -> "http://www.google.com/search?&q=%s"), then dragging the whole phrase (minus the quotes) to the location bar should cause the query to be expanded to "http://www.google.com/search?&q=mozilla". There are lots of situations where this would be useful, such as bugs (when referenced in plain text) and other common repeated nouns. Reproducible: Always Steps to Reproduce:

Probably depends on the affects of bug 285438.

Tweaking summary. Reassigning to Tabbed Browser since this now works for me with the location bar.

The reason that drag & drop gestures for tabs aren't respecting bookmark keywords is that spaces in a bookmark keyword string cause Firefox to bail out before reaching getShortcutOrURI. This is easily fixed by removing the later calls and placing one single call before the validity check.

Based on the code affected, this must be a regression from a long time ago (before 1.0). Upgrading from enhancement to bug.

Comment on attachment 191603 [details] [diff] [review] Use getShortcutOrURI before validity check ooh, bad mojo here. Toolkit can't depend on browser stuff. (The fact that we already do is bad, and we should fix that).

Clearing status whiteboard. Per IRC, this needs to wait until after Firefox 1.5.

Resubmitting now that tabbrowser has been moved from toolkit to browser. On a related note, dropping a bookmark keyword phrase (keyword + string) onto the location bar no longer causes automatic loading. In 2.0, you can still press the "go" button, but in 3.0, the integrated "go" button is not activated on drag/drop of text. Shall I file a bug for this?

Please disregard the "related note" above, as this problem has now gone away.

Comment on attachment 299596 [details] [diff] [review] Unbitrotten I'll try to get to this sometime soon. Moving it to the new review flag so it gets off the "probably obsolete" list.

Comment on attachment 299596 [details] [diff] [review] Unbitrotten this doesn't apply, and I don't have time to clean it up myself. Ben, if you can attach a new patch I should be quick to review...