Closed Bug 299379 Opened 19 years ago Closed 19 years ago

DOMFocusIn/DOMFocusOut not working properly

Categories

(Core Graveyard :: XForms, defect)

Product:
Core Graveyard
Component:
XForms
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stpride, Assigned: doronr)

References

Details

(Keywords: fixed1.8)

Attachments

(2 files, 3 obsolete files)

testcase
(deleted), application/xhtml+xml
Details
even better patch
(deleted), patch
aaronr
: review+
smaug
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050509 Firefox/1.0.4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050509 Firefox/1.0.4 The DOMFocusIn and DOMFocusOut events should be caught when a value is changed for a form control that traps for them, but it doesn't. See testcase. Reproducible: Always
Attached file testcase (deleted) —
Actually, the 1.0 errata removes the mention of the DOM focus events: http://www.w3.org/MarkUp/Forms/Group/Drafts/Sources/errata.html#E70e
Status: UNCONFIRMED → RESOLVED
Closed: 19 years ago
Resolution: --- → INVALID
OK. I missed something. It's not removed, it's just not specified in the value change sequence. They should still be dispatched...
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
Well, the right way to do this is to support DOMFocusIn and DOMFocusOut in the core, which bryner says they will definitely take, but I'm sure it will be too late for FF 1.5. We could dispatch it ourselves as a stop gap until then, though.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 278448
Summary: DOMFocusIn/DOMFocuOut not working properly → DOMFocusIn/DOMFocusOut not working properly
Attached patch le patch (obsolete) (deleted) — — Splinter Review
Assignee: aaronr → doronr
Status: NEW → ASSIGNED
Attachment #199973 - Flags: review?(aaronr)
Attached patch le patch (obsolete) (deleted) — — Splinter Review
Attachment #199974 - Flags: review?(aaronr)
Comment on attachment 199973 [details] [diff] [review] le patch double submit somehow, removing
Attachment #199973 - Attachment is obsolete: true
Attachment #199973 - Flags: review?(aaronr)
Comment on attachment 199974 [details] [diff] [review] le patch So far so good. But looking at the spec looks like DOMFocusIn/Out needs to happen for: input, secret, textarea, output, upload, trigger, range, submit, select, select1, and group. I don't know what we should do for output or group, but the rest seem straight forward.
Attachment #199974 - Flags: review?(aaronr) → review-
Attached patch better patch (obsolete) (deleted) — — Splinter Review
For a full appearance select, this is hard to implement, so XXX: for now.
Attachment #199974 - Attachment is obsolete: true
Attachment #200115 - Flags: review?(aaronr)
Attachment #200115 - Attachment is obsolete: true
Attachment #200115 - Flags: review?(aaronr)
Attached patch even better patch (deleted) — — Splinter Review
Attachment #200143 - Flags: review?(aaronr)
Comment on attachment 200143 [details] [diff] [review] even better patch Looks good. Please open a bug for range and upload to support these (or leave this bug open to account for them).
Attachment #200143 - Flags: review?(aaronr) → review+
Attachment #200143 - Flags: review?(smaug)
Comment on attachment 200143 [details] [diff] [review] even better patch I guess this is ok for now.
Attachment #200143 - Flags: review?(smaug) → review+
Checked into trunk. Do we want this on branch?
Since bug 275453 was fixed then patch should be updated. Now 'upload' element calls removed dispatchDOMActivate() method.
checked into branch.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago → 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: